transpile: Use convert_cast in operators.rs#1703
Merged
kkysen merged 2 commits intoimmunant:masterfrom Apr 3, 2026
Merged
Conversation
This was referenced Mar 28, 2026
kkysen
reviewed
Mar 31, 2026
Contributor
kkysen
left a comment
kkysen
left a comment
There was a problem hiding this comment.
Can you also add before/after snapshot tests for this, too? Note that if the before test fails to compile, we can now handle that with a .expect_compile_error(true).
Rua
force-pushed
the
operators-convert-cast
branch
4 times, most recently
from
d55032c to
c80f39c
Compare
Contributor
Author
|
I added a test to |
Rua
force-pushed
the
operators-convert-cast
branch
2 times, most recently
from
059a175 to
be1db28
Compare
kkysen
reviewed
Mar 31, 2026
Rua
force-pushed
the
operators-convert-cast
branch
from
be1db28 to
5024fba
Compare
kkysen
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|=operator onboolresults in invalid Rust being generated #340The various edge cases in these bits of code were essentially duplicating what
convert_castwas doing, but worse and easier to miss. So this just reuses the more robust logic thatconvert_castalready has for this.