Skip to content

update GHA#375

Open
ElsLommelen wants to merge 2 commits into
masterfrom
node_js24
Open

update GHA#375
ElsLommelen wants to merge 2 commits into
masterfrom
node_js24

Conversation

@ElsLommelen
Copy link
Copy Markdown
Contributor

Description

To solve the warning that Node.js 20 actions are deprecated and should be updated to Node.js 24 before june 2, this PR updates the GHA in this repo. Additional to the required fix, third party actions were updated according to the IT guidelines.

Task list

This is a technical issue and not a new tutorial, so none of the listed tasks apply. I therefore removed the task list, please let me know if there are any requirements in this case.

Previewing the pull request

I'm afraid this preview won't work for this PR, please give any advice on how I can test this.

(I left the below text in, just in case it could be useful.)

Thanks to GitHub Actions, an artifact (=zip file) of the rendered website is automatically created for each pull request.
This provides a way to preview how these updates will look on the website, useful to contributors and reviewers.

Instructions to preview the updated website

  1. On the PR page, you can find a "details" link under "checks - On PR, build the site and ...". Go there, click on the top link in the left sidebar ("Summary"), and download the generated artifact at the bottom of the page.
  2. Decompress it into a target directory, e.g. Downloads/tutorials_preview.
  3. To preview the website, use a program which can serve http sites on your local machine. One such option is the servr package in R: & '\C:\Program Files\R\R-4.4.2\bin\Rscript.exe' -e "servr::httd('./tutorials_preview')" -p8887 (make sure to adjust the path to your Rscript.exe; on Linux, simply use Rscript -e [...]).
  4. Point your browser to http://localhost:8887.
  5. Review the updated website. As a contributor, you can push extra commits to update the PR. As a reviewer, you can accept/refuse/comment the PR.

Note: for step 3, you can use any other simple HTTP server to serve the current directory, e.g. Python http.server: python -m http.server 8887 --bind localhost --directory path/to/tutorials_preview

Alternative: Locally Building the Site

Alternatively, you can build the entire site locally (see the README for instructions); the Hugo preview server will update changes on the fly.
This requires Hugo to be installed on your computer.

@falkmielke
Copy link
Copy Markdown
Contributor

falkmielke commented May 19, 2026

Thank you for bringing in the latest versions, @ElsLommelen !

I'm afraid this preview won't work for this PR, please give any advice on how I can test this.

The GHA artifact is there, and works fine. I could test the build, and the tutorials site looks good. Or did you mean that the build process still uses the dated GHA?

Anyways, the changes are moderate, and easy to roll back in case the GHA fails after merge.

PS: Note that there is also a long-standing need to update Hugo as well (#359). The software currently ships at version 0.161 and we have deprecation warnings pre-0.128.

@ElsLommelen
Copy link
Copy Markdown
Contributor Author

The GHA artifact is there, and works fine. I could test the build, and the tutorials site looks good. Or did you mean that the build process still uses the dated GHA?

I just wasn't sure if the artifact would build in case no content was added to the PR, but indeed, it builds.

PS: Note that there is also a long-standing need to update Hugo as well (#359). The software currently ships at version 0.161 and we have deprecation warnings pre-0.128.

Unfortunately this doesn't look like a 5 minute job, as I have no experience in this. As promised, I will look at it later this year.

@falkmielke
Copy link
Copy Markdown
Contributor

falkmielke commented May 19, 2026

Yes, understood, #359 can be handled separately. I just wasn't sure whether the step to the latest Hugo now happens with switch to newer GHA upstream procedures; the deprecated keywords and settings might break the build procedure upon merge.

Maybe better wait a bit with merging to main; I will double check the hugo update later this week and might solve is with a sub-PR on this PR. Building locally is easy for me, I will try to match the GHA version, and I think I have seen the same deprecations on other Hugo websites and can solve them.

@falkmielke falkmielke self-requested a review May 19, 2026 09:41
Copy link
Copy Markdown
Contributor

@falkmielke falkmielke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-activating my positive evaluation from earlier.

@falkmielke
Copy link
Copy Markdown
Contributor

falkmielke commented May 26, 2026

@ElsLommelen I have double checked this PR and found that the versions of hugo and the minimo theme are hardcoded, so merging should not break website deployment.
I have also worked through the hugo deprecation warnings and will submit a separate PR (#359 ).

falkmielke added a commit that referenced this pull request May 26, 2026
@falkmielke falkmielke mentioned this pull request May 26, 2026
@falkmielke
Copy link
Copy Markdown
Contributor

Side note: the package versions in .github/workflows workflows of the current branch seem to determine which version is used for the artifact preview. Thus, if updating the GHA, and changing the versions, a green light means the changes worked; otherwise you get debugging infos in the summary.

(I noticed that when introducing new hugo syntax prior to updating the workflows, it crashes.)

@ElsLommelen
Copy link
Copy Markdown
Contributor Author

Yes, indeed, I noticed last week while checking the artifact (after you mentioned it was build).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants