Skip to content

protocol: align common status handling - #174

Merged
pcarrier merged 1 commit into
codex/wasmi-plugin-rfcfrom
codex/common-status-cleanup
Aug 5, 2026
Merged

protocol: align common status handling#174
pcarrier merged 1 commit into
codex/wasmi-plugin-rfcfrom
codex/common-status-cleanup

Conversation

@pcarrier

@pcarrier pcarrier commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Move the existing FS/Git/KV/LSP/NET implementations and client diagnostics onto the common status registry proposed by #167.

  • classify malformed Git and LSP inputs as INVALID instead of OTHER
  • make Rust and TypeScript status renderers distinguish declared backend OTHER from unknown numeric status values
  • update existing-family documentation and comments to point at the canonical registry
  • add Rust and TypeScript regression tests

This deliberately excludes the native process RFC, extension runtime work, Git fetch NUL hardening, and Git diff fixture stabilization.

Stack

This is based on #167 because that PR introduces docs/protocol.md#common-status-registry. The code cleanup can be reviewed separately and merged after the base lands.

Verification

  • cargo fmt --check
  • changed Git status cases: open_reports_repo, tree_blob_and_base, and log_follow_directory_and_unknown_flags
  • LSP malformed-path regression
  • four remote status-text regressions
  • TypeScript status-text test
  • tsc --noEmit
  • git diff --check

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

🔗 Preview: https://blit-d7n2e1bi2-indent.vercel.app

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Coverage

Crate Lines Functions Regions
alacritty-driver 69.7% (698/1002) 72.0% (54/75) 71.7% (1050/1464)
browser 0.0% (0/807) 0.0% (0/65) 0.0% (0/1370)
cli 17.2% (1521/8826) 28.1% (200/713) 20.1% (2730/13561)
compositor 9.8% (952/9699) 16.2% (73/450) 9.5% (1225/12962)
fonts 81.4% (721/886) 88.6% (70/79) 83.0% (1427/1719)
fssync 92.5% (4880/5274) 94.1% (445/473) 92.5% (8926/9647)
gateway 25.8% (375/1455) 29.9% (38/127) 19.4% (470/2417)
git 87.6% (4199/4793) 88.8% (333/375) 87.3% (6646/7614)
lsp 76.0% (2503/3295) 78.2% (248/317) 73.8% (3886/5266)
proxy 19.3% (172/892) 20.5% (26/127) 21.2% (293/1381)
remote 90.3% (8650/9575) 93.6% (624/667) 88.1% (14365/16306)
sd-notify 73.9% (68/92) 100.0% (6/6) 83.2% (109/131)
server 38.6% (7046/18262) 52.8% (676/1281) 41.1% (11938/29049)
ssh 1.9% (7/374) 3.2% (1/31) 0.7% (4/613)
upsidedown 31.4% (391/1247) 27.8% (55/198) 34.8% (797/2287)
webrtc-forwarder 2.7% (72/2624) 2.1% (4/187) 1.2% (50/4335)
webserver 60.3% (1051/1742) 64.7% (156/241) 63.1% (1800/2851)
Total 47.0% (33306/70845) 55.6% (3009/5412) 49.3% (55716/112973)

@pcarrier
pcarrier force-pushed the codex/common-status-cleanup branch from 0e54c35 to d1da797 Compare August 5, 2026 19:40
@pcarrier
pcarrier marked this pull request as ready for review August 5, 2026 20:17
@indent

indent Bot commented Aug 5, 2026

Copy link
Copy Markdown

Issues

Review closed.

CI Checks

1 CI check failed on 0e54c35.

Failing lint
  • lint finished with failure.

@pcarrier
pcarrier merged commit 5fcd6d1 into codex/wasmi-plugin-rfc Aug 5, 2026
12 checks passed
@pcarrier
pcarrier deleted the codex/common-status-cleanup branch August 5, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant