Update Reclaimed Time for DHCP Config as ReadOnly Fields#47
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the IPAM DHCPConfig model serialization/docs to treat the “hold reclaimed time” fields as non-writable (excluded from to_dict()), and adjusts their defaulting behavior.
Changes:
- Changes
hold_reclaimed_time/hold_reclaimed_time_v6defaults from3600toNoneand removes thefrom_dict()fallback to3600. - Excludes
hold_reclaimed_time/hold_reclaimed_time_v6fromDHCPConfig.to_dict()output (effectively making them client-non-writable). - Updates
DHCPConfigmarkdown docs to mark these fields as[readonly].
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/ipam/models/dhcp_config.py | Removes defaulting for hold_reclaimed_time* and excludes them from to_dict() output. |
| src/ipam/docs/DHCPConfig.md | Marks hold_reclaimed_time* as read-only in the published model docs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
unasra
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Marks the
reclaimed_timefield on theDHCPConfigmodel as read-only to correctly reflect the upstream IPAM API contract, where this field is server-populated and must not be set by the client.Type of Change
Affected Packages
anycastcloud_discoverydfpdns_configdns_datadtcfwinfra_mgmtinfra_provisionipamipam_federationkeysredirectupgrade_policyuniversal_ddi_clientResource / Model:
DHCPConfigDescription: Changed
reclaimed_timeonDHCPConfigto a read-only field to match the IPAM API schema.Schema Changes
Detailed Changes (click to expand)
src/ipam/models/dhcp_config.pyreclaimed_timeas read-only; removed it from the writable field setsrc/ipam/docs/DHCPConfig.mdreclaimed_timeas read-onlyTicket / Issue
Fixes #
Changelog Inclusion
Additional Context
The
reclaimed_timefield is populated by the IPAM server to record when an address was last reclaimed; it is not a client-settable value. Marking it read-only prevents accidental writes and aligns the Python client with the API's actual behaviour.