Update Cloud Discovery Schemas to add Zone filters and Other Correspondent Field Changes#51
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Cloud Discovery client schema/models to support new DNS zone filtering capabilities and additional provider/config fields, keeping the generated Python models and markdown docs in sync.
Changes:
- Adds the new
ZoneFiltermodel and documentation, and wires it intoDNSConfigvia the newzone_filtersfield. - Extends
DNSConfigwithresolver_endpoints_sync_enabled. - Updates discovery/source configuration schemas (e.g.,
DiscoveryConfig.is_disabled,DiscoveryConfig.labs_provider, and marksSourceConfig.idas read-only/excluded fromto_dict).
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/cloud_discovery/README.md | Adds ZoneFilter to the documented model list. |
| src/cloud_discovery/models/zone_filter.py | Introduces the ZoneFilter Pydantic model. |
| src/cloud_discovery/models/source_config.py | Excludes id from to_dict (read-only) and updates docstring. |
| src/cloud_discovery/models/dns_config.py | Adds resolver endpoint sync flag and zone_filters: List[ZoneFilter] with (de)serialization. |
| src/cloud_discovery/models/discovery_config.py | Adds is_disabled and labs_provider fields to the model. |
| src/cloud_discovery/models/init.py | Exports ZoneFilter from the models package. |
| src/cloud_discovery/docs/ZoneFilter.md | Adds markdown documentation for the new ZoneFilter model. |
| src/cloud_discovery/docs/SourceConfig.md | Marks id as [readonly] in docs. |
| src/cloud_discovery/docs/DNSConfig.md | Documents new DNS config fields (resolver_endpoints_sync_enabled, zone_filters). |
| src/cloud_discovery/docs/DiscoveryConfig.md | Documents new discovery config fields (is_disabled, labs_provider). |
| src/cloud_discovery/init.py | Exports ZoneFilter at the package level. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
unasra
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.