feat(bunyan): added support for error.cause #2331
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryamohanan
changed the title
aryamohanan
changed the title
kirrg001
reviewed
Feb 10, 2026
| // CASE: logger.error(new Error('msg'), 'another msg') | ||
| const errorMessage = tracingUtil.extractErrorMessage(fields); | ||
| message = `${errorMessage} -- ${message}`; | ||
| } else if (fields instanceof Error) { |
Contributor
There was a problem hiding this comment.
I think we can improve the readability here a lot.
const x = fields.err || fields.
+
if (fields instanceof Error) {
const errorMessage = tracingUtil.extractErrorMessage(fields);
if (typeof message === 'string')
....
}
aryamohanan
force-pushed
the
feat-err-cause-bunyan
branch
from
0a70ed0 to
0a25112
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced bunyan instrumentation to support Node.js error.cause feature.
Same did for console, see #2286
ref: https://jsw.ibm.com/browse/INSTA-71403