-
Notifications
You must be signed in to change notification settings - Fork 107
[v12] feat(ui-heading): rework Heading #2365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v12
Are you sure you want to change the base?
Conversation
INSTUI-4869
|
| fontWeight: componentTheme.weightImportant, | ||
| fontSize: componentTheme.titlePageDesktop, | ||
| lineHeight: componentTheme.lineHeight125 | ||
| ...componentTheme.titlePageDesktop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a composit token now
| if (aiVariant === 'stacked') { | ||
| return ( | ||
| <> | ||
| <span css={this.props.styles?.igniteAIStacked}> | ||
| <IconAiColoredSolid /> | ||
| <span css={this.props.styles?.igniteAI}>IgniteAI</span> | ||
| </span> | ||
| {children} | ||
| </> | ||
| ) | ||
| } | ||
| if (aiVariant === 'horizontal') { | ||
| return ( | ||
| <> | ||
| <IconAiColoredSolid /> | ||
| <span css={this.props.styles?.igniteAI}>IgniteAI</span> | ||
| <StarsInstUIIcon color="ai" size="sm" /> | ||
| {children} | ||
| </> | ||
| ) | ||
| } | ||
| if (aiVariant === 'iconOnly') { | ||
| return ( | ||
| <> | ||
| <IconAiColoredSolid /> | ||
| {children} | ||
| </> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is some dead code/duplication as the 'stacked', 'horizontal' and 'iconOnly' AI cases are already checked above...(?)
| return ( | ||
| <span css={[this.props.styles?.withIcon]} aria-hidden="true"> | ||
| {callRenderProp(renderIcon)} {children} | ||
| {renderIconWithProps(renderIcon, iconSize, 'inherit')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| static defaultProps = { | ||
| children: null, | ||
| border: 'none', | ||
| color: 'inherit' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.



INSTUI-4869
ISSUE:
Heading needs to be migrated to the new theming system
TEST PLAN: