Open
Conversation
Merged
ahuber21
approved these changes
Feb 6, 2026
Contributor
ahuber21
left a comment
ahuber21
left a comment
There was a problem hiding this comment.
Very nice! I have just a few nitpicks that would be easy to sort out.
bindings/cpp/src/ivf_index_impl.h
Outdated
|
|
||
| // Dispatch on storage kind for Dynamic IVF operations (uses blocked allocator) | ||
| template <typename F, typename... Args> | ||
| auto dispatch_ivf_blocked_storage_kind(StorageKind kind, F&& f, Args&&... args) { |
Contributor
There was a problem hiding this comment.
I don't see this used anywhere. Will a blocked index be added separately?
bindings/cpp/tests/runtime_test.cpp
Outdated
| CATCH_REQUIRE(status.ok()); | ||
|
|
||
| status = index->compact(); | ||
| CATCH_REQUIRE(status.ok()); |
Contributor
There was a problem hiding this comment.
Maybe also check for smaller size after compacting?
Member
Author
There was a problem hiding this comment.
We have compact related unit tests in the library
Contributor
There was a problem hiding this comment.
This entire file would benefit from a few svs::runtime::v0::... statements for better readability.
Member
Author
There was a problem hiding this comment.
I am just following the existing structure, this could be a separate PR for better readability in vamana/ivf tests
ethanglaser
added a commit
that referenced
this pull request
Feb 10, 2026
ibhati
requested review from
ethanglaser,
homksei,
mihaic and
yuejiaointel
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add IVF static and dynamic index in cpp runtime