[DevSAN] Don't keep original meta data for new SanitizerKernelMetadata #20838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, IGC compiler may not export the SanitizerKernelMetadata as device globals.
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YuriPlyakhin
reviewed
Dec 5, 2025
Contributor
YuriPlyakhin
left a comment
YuriPlyakhin
left a comment
There was a problem hiding this comment.
Could you please provide more details, why this change is needed?
Also, could you please add a lit test that would demonstrate change of behavior (wondering why this change did not impact any existing lit test...)?
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
updated the description and related lit test. |
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YuriPlyakhin
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building device code as spirv obj. The llvm IR/spirv bi-translation process will introduce extra unnecessary metadata for sanitizer globals and cause IGC compiler failed to export it as device global.