[SYCL][ABI-break] Remove fpga features from SYCL RT #20882
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
againull
force-pushed
the
remove_fpga_features
branch
from
600c199 to
502506a
Compare
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
bader
reviewed
Dec 12, 2025
| def AspectExt_intel_gpu_slices : Aspect<"ext_intel_gpu_slices">; | ||
| def AspectExt_intel_gpu_subslices_per_slice : Aspect<"ext_intel_gpu_subslices_per_slice">; | ||
| def AspectExt_intel_gpu_eu_count_per_subslice : Aspect<"ext_intel_gpu_eu_count_per_subslice">; | ||
| def AspectExt_intel_max_mem_bandwidth : Aspect<"ext_intel_max_mem_bandwidth">; |
Contributor
There was a problem hiding this comment.
Doesn't this aspect also apply to FPGA only?
Contributor
There was a problem hiding this comment.
I suppose AspectExt_intel_memory_bus_width and AspectExt_intel_memory_clock_rate are unnecessary as well.
bader
reviewed
Dec 12, 2025
| def : TargetInfo<"spir64", [], [], "", "", 1>; | ||
| def : TargetInfo<"spir64_gen", [], [], "", "", 1>; | ||
| def : TargetInfo<"spir64_x86_64", IntelCpuAspects, [4, 8, 16, 32, 64], "", "", 1>; | ||
| def : TargetInfo<"spir64_fpga", [], [], "", "", 1>; |
Contributor
There was a problem hiding this comment.
I think we can remove spir64_fpga TargetInfo.
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.