Skip to content

[UR][HIP] Make ur_context_handle_t_ destructor non-throwing #20887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kekaczma wants to merge 1 commit into
base: sycl
Choose a base branch
from
+13 −2
Open

[UR][HIP] Make ur_context_handle_t_ destructor non-throwing #20887

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions unified-runtime/source/adapters/hip/context.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,19 @@ struct ur_context_handle_t_ : ur::hip::handle_base {
UR_CHECK_ERROR(urAdapterRetain(ur::hip::adapter));
};

~ur_context_handle_t_() {
UR_CHECK_ERROR(urAdapterRelease(ur::hip::adapter));
~ur_context_handle_t_() noexcept {
try {
auto result = urAdapterRelease(ur::hip::adapter);
if (result != UR_RESULT_SUCCESS) {
UR_LOG(ERR, "Failed to release adapter in context destructor: {}",
result);
}
assert(result == UR_RESULT_SUCCESS &&
"Adapter release failed in context destructor");
} catch (...) {
UR_LOG(ERR, "Exception in context destructor");
assert(false && "Exception in context destructor");
}
}

ur_context_handle_t_(const ur_context_handle_t_ &) = delete;
Expand Down
Loading