Enable readability-string-compare and fix warning#565
Open
gaul wants to merge 1 commit intointel:thermald_nextfrom
Open
Enable readability-string-compare and fix warning#565gaul wants to merge 1 commit intointel:thermald_nextfrom
gaul wants to merge 1 commit intointel:thermald_nextfrom
Conversation
Signed-off-by: Andrew Gaul <andrew@gaul.org>
There was a problem hiding this comment.
Pull request overview
This PR enables the readability-string-compare clang-tidy check and updates code to satisfy the new warning by replacing std::string::compare(...)-based equality with operator==.
Changes:
- Enable
readability-string-comparein.clang-tidy. - Replace
!std::string::compare(...)with==for string equality incthd_gddv::get_trip_temp().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/thd_gddv.cpp |
Uses operator== for string equality to comply with readability-string-compare. |
.clang-tidy |
Enables readability-string-compare in the project’s clang-tidy configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.