Fixing anyOf/oneOf without schema $ref properties and Link titles with parentheses #59
+195
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h parentheses
The code assumed that anyOf and oneOf arrays always contain schemas with $ref properties.
Schemas like this one...
```json
"anyOf": [
{
"required": ["cloud", "suite"],
"additionalProperties": true
},
{
"required": ["cloud", "tags"],
"additionalProperties": true
}
]
```
...caused this error: "runtime error: invalid memory address or nil pointer dereference"
To fix it I added nil checks
Also if a Link title used parentheses the generated Go code was invalid.
To fix it I added parentheses to the regex used to split Link titles.
I also add it go.mod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code assumed that anyOf and oneOf arrays always contain schemas with $ref properties.
Schemas like this one...
...caused this error: "runtime error: invalid memory address or nil pointer dereference"
To fix it I added nil checks.
Also if a Link title used parentheses the generated Go code was invalid.
To fix it I added parentheses to the regex used to split Link titles.
I also add it go.mod
Here is a schema file that could be used to reproduce the original issues.