docs: Refactor Crashlytics usage to use new API methods#8935
docs: Refactor Crashlytics usage to use new API methods#8935NaNtrack wants to merge 1 commit intoinvertase:mainfrom
Conversation
|
@NaNtrack is attempting to deploy a commit to the Invertase Team on Vercel. A member of the Team first needs to authorize it. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Crashlytics documentation examples to reflect a change in the API usage pattern. The modifications ensure that the code snippets provided in the documentation are current and demonstrate the recommended way to interact with the Crashlytics module, improving clarity and consistency for developers integrating Crashlytics into their applications. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the Crashlytics usage in the documentation examples to align with the new modular API. The changes correctly apply the new API patterns. I have one suggestion to improve the code style in one of the examples by using async/await more consistently, which will enhance readability.
| await setCrashlyticsCollectionEnabled(crashlytics, !enabled) | ||
| .then(() => setEnabled(crashlytics.isCrashlyticsCollectionEnabled)); |
There was a problem hiding this comment.
For better readability and consistency, you can refactor this to use async/await exclusively, instead of mixing it with .then().
| await setCrashlyticsCollectionEnabled(crashlytics, !enabled) | |
| .then(() => setEnabled(crashlytics.isCrashlyticsCollectionEnabled)); | |
| await setCrashlyticsCollectionEnabled(crashlytics, !enabled); | |
| setEnabled(crashlytics.isCrashlyticsCollectionEnabled); |
Description
Refactor Crashlytics usage to use new API methods
Related issues
None
Release Summary
Refactor Crashlytics usage to use new API methods
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Not needed