Skip to content

docs: Refactor Crashlytics usage to use new API methods#8935

Open
NaNtrack wants to merge 1 commit intoinvertase:mainfrom
NaNtrack:patch-2
Open

docs: Refactor Crashlytics usage to use new API methods#8935
NaNtrack wants to merge 1 commit intoinvertase:mainfrom
NaNtrack:patch-2

Conversation

@NaNtrack
Copy link

Description

Refactor Crashlytics usage to use new API methods

Related issues

None

Release Summary

Refactor Crashlytics usage to use new API methods

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Not needed

@vercel
Copy link

vercel bot commented Mar 19, 2026

@NaNtrack is attempting to deploy a commit to the Invertase Team on Vercel.

A member of the Team first needs to authorize it.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Crashlytics documentation examples to reflect a change in the API usage pattern. The modifications ensure that the code snippets provided in the documentation are current and demonstrate the recommended way to interact with the Crashlytics module, improving clarity and consistency for developers integrating Crashlytics into their applications.

Highlights

  • API Refactoring: Refactored Crashlytics usage examples in the documentation to align with new API methods, moving from instance-based method calls (e.g., crashlytics().log()) to named export functions that accept the Crashlytics instance as the first argument (e.g., log(crashlytics, 'message')).
  • Import Structure: Updated import statements to specifically import individual Crashlytics functions like getCrashlytics, log, setUserId, setAttribute, setAttributes, crash, recordError, and setCrashlyticsCollectionEnabled from @react-native-firebase/crashlytics.
  • Instance Initialization: Introduced a const crashlytics = getCrashlytics(); call to obtain the Crashlytics instance once, which is then passed to the new API functions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Crashlytics usage in the documentation examples to align with the new modular API. The changes correctly apply the new API patterns. I have one suggestion to improve the code style in one of the examples by using async/await more consistently, which will enhance readability.

Comment on lines +173 to +174
await setCrashlyticsCollectionEnabled(crashlytics, !enabled)
.then(() => setEnabled(crashlytics.isCrashlyticsCollectionEnabled));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and consistency, you can refactor this to use async/await exclusively, instead of mixing it with .then().

Suggested change
await setCrashlyticsCollectionEnabled(crashlytics, !enabled)
.then(() => setEnabled(crashlytics.isCrashlyticsCollectionEnabled));
await setCrashlyticsCollectionEnabled(crashlytics, !enabled);
setEnabled(crashlytics.isCrashlyticsCollectionEnabled);

@NaNtrack NaNtrack changed the title Refactor Crashlytics usage to use new API methods docs: Refactor Crashlytics usage to use new API methods Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant