Skip to content

refactor(auth)!: Migrate to typescript#8936

Draft
MichaelVerdon wants to merge 13 commits intomainfrom
auth-typescript
Draft

refactor(auth)!: Migrate to typescript#8936
MichaelVerdon wants to merge 13 commits intomainfrom
auth-typescript

Conversation

@MichaelVerdon
Copy link
Collaborator

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Mar 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-native-firebase Error Error Mar 20, 2026 2:53pm

Request Review

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring of the auth package, migrating its entire codebase to TypeScript. This transition enhances code quality, maintainability, and developer experience by introducing strong typing across the module's classes, methods, and internal structures. The changes also include updates to the modular API and minor adjustments to Firestore's query constraints to accommodate the new typing paradigm.

Highlights

  • TypeScript Migration: The core auth package has been refactored and migrated to TypeScript, converting existing JavaScript files to .ts and adding comprehensive type definitions.
  • File Renames and Additions: Several key files like ConfirmationResult, Settings, User, MultiFactorResolver, and getMultiFactorResolver have been renamed from .js to .ts and updated with type annotations. New TypeScript type definition files (types/auth.ts, types/internal.ts, types/namespaced.d.ts) and a new modular API implementation (modular.ts) were added.
  • Modular API Refactoring: The modular API implementation has been refactored to align with TypeScript, including the removal of old JavaScript and declaration files for modular components.
  • Firestore Query Enhancements: Minor updates were made to Firestore's modular query system, introducing a QueryConstraint interface and QueryConstraintBase class, and extending QueryConstraintType to support 'or' and 'and' composite filters.
  • Build Configuration Updates: New tsconfig.json files were added for the auth package, and the root tsconfig.json was updated to correctly resolve TypeScript paths for @react-native-firebase/* packages.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully migrates several core authentication files to TypeScript, significantly improving type safety and code clarity across the auth package. The changes involve adding explicit type annotations, refining interfaces, and updating the build configuration to support TypeScript compilation. The refactoring of Firestore query constraints also enhances type safety in that module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant