CallHierarchyOutgoingCalls #1418
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements the CallHierarchyOutgoingCalls LSP feature for FsAutoComplete, enabling editors to navigate from a function to all the functions it calls. The implementation includes both the core server functionality and comprehensive test coverage.
Key changes:
- Added full implementation of CallHierarchyOutgoingCalls functionality
- Created extensive test suite with multiple complex scenarios
- Added test case files covering various call patterns (simple, recursive, nested, async)
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/FsAutoComplete/LspServers/AdaptiveFSharpLspServer.fs | Main implementation of CallHierarchyOutgoingCalls endpoint with symbol analysis and filtering |
| test/FsAutoComplete.Tests.Lsp/CallHierarchyTests.fs | Comprehensive test suite with 8 test cases covering various call hierarchy scenarios |
| test/FsAutoComplete.Tests.Lsp/Program.fs | Added import for new CallHierarchy test module |
| test/FsAutoComplete.Tests.Lsp/FsAutoComplete.Tests.Lsp.fsproj | Added compiler warning suppression for test project |
| TestCases/CallHierarchy/OutgoingCalls/*.fsx | Test case files providing examples of different call patterns |
| Various other files | Test files, configuration files, and documentation updates |
- Implemented CallHierarchyOutgoingCalls in AdaptiveFSharpLspServer. - Added tests for outgoing calls in CallHierarchyTests. - Created example files for outgoing calls scenarios. - Updated project files to include new tests and configurations.
… filtering and updating test cases for accuracy
…recursion, mutual recursion, tree traversal, and async patterns
…veFSharpLspServer
TheAngryByrd
force-pushed
the
outgoing-calls
branch
from
77e1e6c to
0de2bf4
Compare
…tions, operators, and properties
TheAngryByrd
force-pushed
the
outgoing-calls
branch
from
0de2bf4 to
4e76a5e
Compare
…ws in NestedExample2
…hy, enhancing resolution of local file paths and adding related tests.
… external build paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds callHierarchy/outgoingCalls
This shows all functions being used within an expression.
callhierarchyoutgoing.mp4