Skip to content
99 changes: 99 additions & 0 deletions kubernetes/customresourcedefinitions.gen.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

31 changes: 27 additions & 4 deletions networking/v1alpha3/destination_rule.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions networking/v1alpha3/destination_rule.pb.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions networking/v1alpha3/destination_rule.proto
Original file line number Diff line number Diff line change
Expand Up @@ -864,6 +864,21 @@ message OutlierDetection {
// disabled by setting it to 0%. The default is 0% as it's not typically
// applicable in k8s environments with few pods per service.
int32 min_health_percent = 5;

// Specifies the HTTP response status codes that are treated as outlier
// detection errors. If specified, only responses with one of these status
// codes will be treated as errors by outlier detection. If not specified,
// only 5xx responses are treated as errors.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the outliers are detected based on consecutive5xx and consecutiveGatewayErrors fields.

//
// Note: Host ejection is still driven by the `consecutive5xxErrors` and
// `consecutiveGatewayErrors` thresholds; this field only redefines which
// HTTP status codes are counted as errors toward those thresholds.
//
// Values must be in the range [100, 599].
//
// +protoc-gen-crd:list-value-validation:Minimum=100
// +protoc-gen-crd:list-value-validation:Maximum=599
repeated uint32 outlier_detection_http_error_codes = 10;
Comment on lines +867 to +881

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Specifies the HTTP response status codes that are treated as outlier
// detection errors. If specified, only responses with one of these status
// codes will be treated as errors by outlier detection. If not specified,
// only 5xx responses are treated as errors.
//
// Values must be in the range [100, 599].
//
// +protoc-gen-crd:list-value-validation:Minimum=100
// +protoc-gen-crd:list-value-validation:Maximum=599
repeated uint32 outlier_detection_http_error_codes = 10;
// Specifies the HTTP response status codes that are treated as outlier
// detection errors. If specified, only responses with one of these status
// codes will be treated as errors by outlier detection. If not specified,
// only 5xx responses are treated as errors.
//
// Note: Host ejection is still driven by the `consecutive5xxErrors` and
// `consecutiveGatewayErrors` thresholds; this field only redefines which
// HTTP status codes are counted as errors toward those thresholds.
//
// Values must be in the range [100, 599].
//
// +protoc-gen-crd:list-value-validation:Minimum=100
// +protoc-gen-crd:list-value-validation:Maximum=599
repeated uint32 outlier_detection_http_error_codes = 10;

}

// SSL/TLS related settings for upstream connections. See Envoy's [TLS
Expand Down