-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add low-level hook for SDL3 input events #2867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ivan1pl
wants to merge
2
commits into
jMonkeyEngine:master
Choose a base branch
from
Ivan1pl:issue/2864/SDL3-low-level-input-event
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+80
−9
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
51 changes: 51 additions & 0 deletions
51
jme3-lwjgl3/src/main/java/com/jme3/input/lwjgl/SdlEventListener.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| /* | ||
| * Copyright (c) 2009-2026 jMonkeyEngine | ||
| * All rights reserved. | ||
| * | ||
| * Redistribution and use in source and binary forms, with or without | ||
| * modification, are permitted provided that the following conditions are | ||
| * met: | ||
| * | ||
| * * Redistributions of source code must retain the above copyright | ||
| * notice, this list of conditions and the following disclaimer. | ||
| * | ||
| * * Redistributions in binary form must reproduce the above copyright | ||
| * notice, this list of conditions and the following disclaimer in the | ||
| * documentation and/or other materials provided with the distribution. | ||
| * | ||
| * * Neither the name of 'jMonkeyEngine' nor the names of its contributors | ||
| * may be used to endorse or promote products derived from this software | ||
| * without specific prior written permission. | ||
| * | ||
| * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
| * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED | ||
| * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR | ||
| * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR | ||
| * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, | ||
| * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, | ||
| * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR | ||
| * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF | ||
| * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING | ||
| * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS | ||
| * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
| package com.jme3.input.lwjgl; | ||
|
|
||
| import com.jme3.system.lwjgl.LwjglWindow; | ||
| import org.lwjgl.sdl.SDL_Event; | ||
|
|
||
| /** | ||
| * Listen to raw SDL events. | ||
| * | ||
| * @author Ivan1pl | ||
| */ | ||
| public interface SdlEventListener { | ||
|
|
||
| /** | ||
| * When registered by {@link LwjglWindow#registerSdlEventListener(SdlEventListener)}, | ||
| * it gets invoked on each polled SDL event before it is passed to jME inputs. | ||
| * | ||
| * @param event SDL event to handle | ||
| */ | ||
| void onSDLEvent(SDL_Event event); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if
registerSdlEventListener(...)could be renamed toaddSdlEventListener(...)for consistency withremoveSdlEventListener(...).Using complementary method pairs (
add/remove,get/set, etc.) is a well-established Java API convention and tends to make APIs more intuitive. Since the method simply adds the listener to an internal collection,addSdlEventListener()also seems to better reflect what it actually does.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. I went for consistency with existing API for
WindowSizeListener:registerWindowSizeListenerandremoveWindowSizeListener. With that in mind, should I rename this toaddSdlEventListener, or keep it as it is?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, and I owe you an apology for assuming your suggestion was inconsistent with the existing API. Your reply made it clear that you were actually following the current
WindowSizeListenernaming (registerWindowSizeListener/removeWindowSizeListener).At this point, I see two possible approaches:
Adopt the
add/removeconvention for new APIs. In that case, this PR could introduceaddSdlEventListener()/removeSdlEventListener(), and a follow-up PR could deprecateregisterWindowSizeListener()in favor ofaddWindowSizeListener(), while keeping backward compatibility for the time being.Keep consistency with the existing API. That would mean naming the new methods
registerSdlEventListener()/removeSdlEventListener(), matching the currentWindowSizeListenerAPI even though theregister/removepairing is less consistent with common Java naming conventions.That said, this is only my opinion. The final decision on API direction should rest with the engine maintainers.
@riccardobl