-
Notifications
You must be signed in to change notification settings - Fork 590
Convert SearchResults/index to functional component #3069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Convert SearchResults/index to functional component #3069
Conversation
Signed-off-by: JeevaRamanathan <[email protected]>
Signed-off-by: JeevaRamanathan <[email protected]>
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3069 +/- ##
==========================================
- Coverage 98.14% 98.12% -0.02%
==========================================
Files 257 257
Lines 8065 8066 +1
Branches 2031 2033 +2
==========================================
Hits 7915 7915
- Misses 150 151 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
does this needs increase in test coverage? |
Signed-off-by: JeevaRamanathan <[email protected]>
packages/jaeger-ui/src/components/SearchTracePage/SearchResults/index.test.js
Outdated
Show resolved
Hide resolved
|
Hi @yurishkuro, I have increased the test coverage |
Signed-off-by: JeevaRamanathan <[email protected]>
packages/jaeger-ui/src/components/SearchTracePage/SearchResults/index.test.js
Outdated
Show resolved
Hide resolved
Signed-off-by: JeevaRamanathan <[email protected]>
|
Hi @yurishkuro, a gentle remainder on the open PRs to be reviewed. Please let me know if any changes are needed |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. You may re-open it if you need more time. |
|
@JeevaRamanathan can you please resolve conflicts? |
Which problem is this PR solving?
Description of the changes
packages/jaeger-ui/src/components/SearchTracePage/SearchResults/index.tsxfrom class to functionalHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test