Skip to content

Conversation

@JeevaRamanathan
Copy link
Contributor

@JeevaRamanathan JeevaRamanathan commented Sep 8, 2025

Which problem is this PR solving?

Description of the changes

  • convert packages/jaeger-ui/src/components/SearchTracePage/SearchResults/index.tsx from class to functional

How was this change tested?

  • Ensured there is no break in the functionality in UI
  • Ran the test suite using npm run test to ensure all test cases pass.
image

Checklist

@JeevaRamanathan JeevaRamanathan requested a review from a team as a code owner September 8, 2025 09:55
@JeevaRamanathan JeevaRamanathan requested review from joe-elliott and removed request for a team September 8, 2025 09:55
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 8, 2025

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

❌ Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.12%. Comparing base (1694678) to head (8c5c709).
⚠️ Report is 62 commits behind head on main.

Files with missing lines Patch % Lines
...components/SearchTracePage/SearchResults/index.tsx 96.07% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3069      +/-   ##
==========================================
- Coverage   98.14%   98.12%   -0.02%     
==========================================
  Files         257      257              
  Lines        8065     8066       +1     
  Branches     2031     2033       +2     
==========================================
  Hits         7915     7915              
- Misses        150      151       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JeevaRamanathan JeevaRamanathan changed the title refactor: convert SearchResults/index to functional component Convert SearchResults/index to functional component Sep 9, 2025
@yurishkuro yurishkuro added the changelog:refactoring Internal, non-functional code improvements label Sep 13, 2025
yurishkuro
yurishkuro previously approved these changes Sep 13, 2025
@yurishkuro
Copy link
Member

does this needs increase in test coverage?

@JeevaRamanathan
Copy link
Contributor Author

Hi @yurishkuro, I have increased the test coverage

Signed-off-by: JeevaRamanathan <[email protected]>
Signed-off-by: JeevaRamanathan <[email protected]>
@JeevaRamanathan
Copy link
Contributor Author

Hi @yurishkuro, a gentle remainder on the open PRs to be reviewed. Please let me know if any changes are needed

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. You may re-open it if you need more time.

@github-actions github-actions bot added the stale label Nov 24, 2025
@yurishkuro
Copy link
Member

@JeevaRamanathan can you please resolve conflicts?

@github-actions github-actions bot removed the stale label Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:refactoring Internal, non-functional code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants