Check for translation missing accelerator keys#3635
Open
softins wants to merge 1 commit intojamulussoftware:mainfrom
Open
Check for translation missing accelerator keys#3635softins wants to merge 1 commit intojamulussoftware:mainfrom
softins wants to merge 1 commit intojamulussoftware:mainfrom
Conversation
5ec65c2 to
982c054
Compare
pljones
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Adds a check to
tools/checkkeys.plto display a warning if an original English string contains an &accelerator key and the corresponding translation does not.CHANGELOG: Tools: Updated checkkeys.pl to flag missing accelerator key in translation.
Context: Fixes an issue?
Just a useful check I thought of when reviewing #3620 and noticed a translation had not included an accelerator key, when there was one in the English original. This is the output for the current tree of that PR:
So it flagged up a couple of other existing translations, in addition to the new one I noticed initially.
Does this change need documentation? What needs to be documented and how?
Not really.
Status of this Pull Request
Ready
What is missing until this pull request can be merged?
Just review.
Checklist