Skip to content

cacheable-request - chore: upgrading sqlite3 to latest#1634

Merged
jaredwray merged 2 commits into
mainfrom
cacheable-request---chore-upgrading-sqlite3-to-latest
May 7, 2026
Merged

cacheable-request - chore: upgrading sqlite3 to latest#1634
jaredwray merged 2 commits into
mainfrom
cacheable-request---chore-upgrading-sqlite3-to-latest

Conversation

@jaredwray
Copy link
Copy Markdown
Owner

@jaredwray jaredwray commented May 7, 2026

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines and Code of Conduct
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
cacheable-request - chore: upgrading sqlite3 to latest

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates various dependencies across the project, including sqlite3, rollup, and several utility packages. A critical issue was identified regarding the sqlite3 upgrade to version 6.0.1, which requires Node.js 20.17.0 or higher, conflicting with the current engines field specifying Node.js 18. The reviewer suggests either reverting the sqlite3 version or updating the engines field to reflect the new requirement.

Comment thread packages/cacheable-request/package.json
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (752eeff) to head (80eaf0d).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1634   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         2496      2496           
  Branches       555       555           
=========================================
  Hits          2496      2496           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray jaredwray merged commit 2968414 into main May 7, 2026
10 checks passed
@jaredwray jaredwray deleted the cacheable-request---chore-upgrading-sqlite3-to-latest branch May 7, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant