Open
Conversation
Correct possible typos in list of build platforms. Change enables arm64 linux builds.
Owner
|
I went way back using git blame and cannot understand why I duplicated those lines in the first place. Thanks for looking into this. If CI passes I'm happy to merge this. |
Author
|
I just realised I don't think it will because arm64 runners are only a beta feature still on github actions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm assuming the list of build platforms is supposed to contain the arm targets rather than duplicate x86 ones?
I've come back to this because some of my own CI on ARM for other projects has started failing when its building parasail python module from source. Seems most sensible to fix the issue at source for everyone.