fixed readme formatting and issue#299#301
Open
YashBhatt2 wants to merge 1 commit intojimmysong:masterfrom
Open
fixed readme formatting and issue#299#301YashBhatt2 wants to merge 1 commit intojimmysong:masterfrom
YashBhatt2 wants to merge 1 commit intojimmysong:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed the readme formatting issues, one problem I had while cloning was while setting up virtual environment, the command mentioned doesnt work anymore for macos and linux, so updated that to the new one, and added another "built in venv module mode" for windows when running virtual environment.
Fixes #299
in ch13.asciidoc <<chapter_p2sh>> text was there instead of intended links, which were replaced.
Love your book, thanks for everything! :)