fix(release): pass --repo to gh release download in verify-signing - #56
Merged
Conversation
The verify-signing job has no checkout, so gh could not infer the repo and failed with 'not a git repository'. Pin --repo like the image attestation step already does. The v0.4.0 release itself published and signed correctly; only this self-check job failed. Refs #15 🔏 - Generated by Copilot
Contributor
There was a problem hiding this comment.
🟢 Ready to approve
The change is a minimal, correct fix that aligns with existing usage in the same workflow and addresses the stated failure mode.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Fixes the verify-signing release gate in the GitHub Actions release workflow by making gh release download explicitly target the current repository even when the job does not perform a checkout.
Changes:
- Add
--repo "${GITHUB_REPOSITORY}"togh release downloadin theverify-signingjob to avoid “fatal: not a git repository” when no checkout is present.
File summaries
| File | Description |
|---|---|
| .github/workflows/release.yml | Ensures verify-signing can download release assets without relying on a local git checkout by passing --repo. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first GA tag
v0.4.0exercised the newverify-signinggate, which failed — but only because of a bug in the gate itself, not the release.What happened
compose-release, andpublish-releasesucceeded. The GA is fully published, images are attested, and the bundle is cosign-signed.verify-signingfailed atgh release downloadwithfatal: not a git repository. The job has no checkout, soghcouldn't infer the repo.Fix
Add
--repo "${GITHUB_REPOSITORY}"togh release download, matching what the image attestation step already does. One line.Independent confirmation the GA is properly signed
gh attestation verify oci://ghcr.io/jmservera/uberos/frontend:0.4.0 --repo jmservera/UbeROS→ exit 0 (verified).v0.4.0-beta.2(cosign verify-blob --new-bundle-format→Verified OK); same pipeline producedv0.4.0.Validation
actionlint release.yml→ clean.Refs #15