remove asciitable from dependeny tree#351
Merged
mpollmeier merged 1 commit intomasterfrom Mar 9, 2026
Merged
Conversation
asciitable is only used for a simple use case, which is tested in TableTests.scala. It happens to have quite a large dependendency tree: ascii-utf-themes, skb-interfaces, ST4, antlr4 (with icu4j), antlr-runtime, javax.json, org.abego.treelayout, and antlr4-runtime. And javax.json is GPL (dual) licensed. Not the end of the world, but it's better to just replace it with a simple implementation IMO.
max-leuthaeuser
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asciitable is only used for a simple use case, which is tested in
TableTests.scala. It happens to have quite a large dependendency tree:
ascii-utf-themes, skb-interfaces, ST4, antlr4 (with icu4j), antlr-runtime,
javax.json, org.abego.treelayout, and antlr4-runtime.
And javax.json is GPL (dual) licensed. Not the end of the world, but
it's better to just replace it with a simple implementation IMO.