fix: consolidate storage class settings and fix env var name mismatch - #581
Open
ulbi wants to merge 3 commits into
Open
fix: consolidate storage class settings and fix env var name mismatch#581ulbi wants to merge 3 commits into
ulbi wants to merge 3 commits into
Conversation
BUG FIX: The env var name in secrets.yaml was OPTIO_AGENT_PVC_STORAGE_CLASS but repo-pool-service.ts reads OPTIO_HOME_PVC_STORAGE_CLASS - they never matched, so home PVC storage class/size always fell back to cluster default. CONSOLIDATION: Reduced 4 separate storage class settings in Helm values to 2 unified keys under storageClass: - storageClass.home / storageClass.homeSize: for repo pod home PVCs + installed-skills cache - storageClass.cache: for shared directory cache PVCs BACKWARD COMPATIBILITY: All deprecated keys (agent.pvc.storageClass, agent.pvc.size, agent.cache.storageClass, installedSkillsCache.storageClass) still work as fallbacks. API logs deprecation warnings when old env vars are used. FILES CHANGED: - helm/optio/values.yaml: Added storageClass.home, storageClass.homeSize, storageClass.cache - helm/optio/templates/secrets.yaml: Fixed env var names + backward compat fallbacks - helm/optio/templates/agent-pvc.yaml: ConfigMap uses unified keys with fallbacks - helm/optio/templates/installed-skills-pvc.yaml: Uses storageClass.home with fallback - apps/api/src/services/repo-pool-service.ts: Deprecation warnings + fallback reads
This ensures old env var keys (OPTIO_AGENT_PVC_*) are removed from the secret when helm upgrade runs, instead of accumulating stale keys.
The helm.sh/hook on the Secret itself caused it to not be rendered in the release manifest, resulting in missing optio-config secret after upgrade. Solution: - Secret is now a normal resource (no hook annotations) - New pre-upgrade Job (secret-cleanup-hook.yaml) deletes stale secret before upgrade and cleans itself up after success.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Tests
Error unable to check Chart.yaml file in chart: stat Chart.yaml: no such file or directory.