Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems wasteful to copy the functions in
copy_tobefore it goes through theIndexMapwhen we also copy the function when it arrives in the model because we don't allow aMOI.ModelLiketo keep a copy of the function.For most implementation of
MOI.ModelLike,MOI.ConstraintFunctiondoes create a new copy but forMOI.Utilities.VectorOfConstraints, it is actually making a copy.What's a bit inconsistent is that
MOI.Utilities.ObjectiveContainerdoes not create a copy of the objective function at the moment. With this PR, the way we handle objective and constraints are not consistent.Removes the need for #2803
Closes #2803