feat!: execute commands for orbiter id specified in juno.config #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, all commands for mission control and orbiter are run based on the entities configured in the CLI configuration - not the
juno.config.It makes sense because generally developers have one mission control and one orbiter regardless if they use profile or not.
While this statement is still correct for the mission control, the orbiter is a bit more a grey area. Developers can also spin orbiters for local development now (using Skylab) plus we generally start using the CLI config more as a "list of things available" than a "source for the IDs".
And it's also possible to reuse an access key while login in - i.e. to login on an orbiter or satellite but to not update the CLI config.
Long story short, this is a breaking change but, the idea it to run the commands for the Orbiter ID specified in the
juno.config. Similar to Satellite ultimately.