Fixes a hang caused by improper error propagation in the creation of a transfer.#226
Merged
Conversation
…a transfer. Closes #225
Contributor
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
==========================================
- Coverage 59.32% 59.24% -0.09%
==========================================
Files 34 34
Lines 4605 4615 +10
==========================================
+ Hits 2732 2734 +2
- Misses 1558 1564 +6
- Partials 315 317 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mattldawson
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of trying to return an error on a channel in which it's not expected, a transfer entry is created with a failed status when an error occurs in the validation of its specification.
Closes #225