feat(lookup): Replace labels matching the artist name with [no label] - #241
feat(lookup): Replace labels matching the artist name with [no label]#241po5 wants to merge 1 commit into
Conversation
|
Just noting sometimes real labels appear in release artists. E.g.
BTW, I have also such a feature in my Harmony enhancements userscript. Details
High-Level Summary
Detailed Comparison Breakdown
Key Observations & Edge Cases
|
|
It is possible to discover if there's an actual label on MB pointing to a particular bandcamp page. If yes, in that case we probably shouldn't set it to |
kellnerd
left a comment
There was a problem hiding this comment.
Thank you for the PR and the test cases @po5, and thank you for the feedback @chaban-mb and @arsinclair.
The feedback which @chaban-mb hides in the details pretty much covers everything I could have brought up and I would like to see those suggestions addressed. Especially the idea to "remove" artist names from the label name and see what remains and the safeguard for labels that could be matched against MB and therefore have an MBID (the Bandcamp example by @arsinclair is covered by this).
Regarding the opposite scenario of labels in the artist credits: Unfortunately we can only catch those if the label has an MBID (and could potentially "fix" the artist credit instead), which is rarely the case with the existing sources.
In all other cases, Harmony at least shows the original values of the label field for all providers since we are only overwriting them with [no label] at the post-merge stage.
See MusicBrainz guide guidelines.