Fix trailing ATR look-ahead bias#1368
Open
Jaco-Ren wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TrailingStrategyATR values, which used future volatility during the rolling warmup windowset_trailing_pct()stable by averaging only finite close/ATR ratiosMotivation and Context
Fixes #963.
TrailingStrategy.set_atr_periods()previously used.bfill()after the rolling ATR calculation. That filled the warmup bars with ATR values computed from later bars, so strategies could open early trades whose trailing stop used future information.With this change, early ATR entries remain
NaN.TrailingStrategy.next()ignores those bars for stop updates and starts applying trailing stops once the rolling ATR window is actually available.Testing
python -m pytest backtesting/test/_test.py -qgit diff --checkpython -m py_compile backtesting\lib.py backtesting\test\_test.py