nvidia-smi check despite manual version input#876
Open
DTJW92 wants to merge 6 commits intokeylase:masterfrom
Open
nvidia-smi check despite manual version input#876DTJW92 wants to merge 6 commits intokeylase:masterfrom
DTJW92 wants to merge 6 commits intokeylase:masterfrom
Conversation
Author
|
Check the newest commit, be27a30. Really quite a simple fix. |
Author
|
Also updated patch-fbc.sh the same, commit b7dba04 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of proposed changes
nvidia-smi is still being called when -d is being used. -d should allow skipping nvidia-smi since you're manually telling the patcher which driver version is being used. If a manual version is submitted, then nvidia-smi check should be skipped.
Essential steps taken
All I did was move manual version check ahead of nvidia-smi check, and skipped the nvidia-smi check if the manual version was submitted.
For context; my Linux system is Batocera, by it's nature it's very minimal and as such nvidia-smi is not included (despite updated drivers).