fix: Start to incorporate lang in URL paths 🌋 by darcywong00 · Pull Request #704 · keymanapp/keyman.com

darcywong00 · 2026-03-31T03:39:53Z

Follows #696

This overhauls .htaccess files to handle a langtag in the URL path (rewrite to corresponding _content/ path).
Flow of .htaccess:

Redirections before rewriting
Remove file extensions from links
Known path redirections
i18n redirect --> /file to <lang>/file
Rewrite rules

Additional small changes:

Moved ‎_content/archive/.htaccess rule to the root .htaccess
cleanup downloads path
cleanup some _test page links

CI link checker ~~will~~ may still fail

Test-bot: skip

* From rubber-ducky with MD

keymanapp-test-bot · 2026-03-31T03:39:58Z

User Test Results

Test specification and instructions

User tests are not required

* These folders don't use _content

1. remove .php / .md 2. redirects before rewrites 3. rewrite locale to lang= parameter 4. final cleanup

also cleaned up test pages

darcywong00 · 2026-04-07T00:53:32Z

@@ -0,0 +1,4 @@
+<?php
+    // Redirect to Android homepage
+    header('Location: https://help.keyman.com/products/android/');


Converted from /_content/android/app/.htaccess - also done for iphone-and-ipad/app

Root .htaccess rules weren't matching

I'm a little uncomfortable with this change -- it might be better to add the rule at the top level .htaccess?

ok, will convert this too top level .htaccess rule(s)

mcdurdin · 2026-04-07T14:12:56Z

  </div>
  <div class="download-cta-small iPad" id="cta-iPad">
-    <a href="../../../ipad/">
+    <a href="../../../../ipad/">


mcdurdin · 2026-04-07T14:13:47Z

 </p>
 <p>
-    <span class="red">A.</span> Yes, you can find the links to download Keyman Desktop 7.1 and other previous releases <a href="../archive/downloads.php">here</a>.
+    <span class="red">A.</span> Yes, you can find the links to download Keyman Desktop 7.1 and other previous releases <a href="/archive/downloads">here</a>.


Suggested change

<span class="red">A.</span> Yes, you can find the links to download Keyman Desktop 7.1 and other previous releases <a href="/archive/downloads">here</a>.

<span class="red">A.</span> Yes, you can find the links to download Keyman Desktop 7.1 and other previous releases <a href="../archive/downloads">here</a>.

Why make the path absolute again?

This depends on the root level redirect

keyman.com/.htaccess

Lines 64 to 65 in 11c3a70

# Redirect /archive/downloads.php"

RewriteRule "^archive/downloads(.php)?$" "/downloads/archive/" [NC,R=301,QSA]

When I make it relative path, I get a 404

Since this is our own link, maybe I should just fix it to ../downloads/archive

Definitely we should fix the link on our site, no point in additional complexity and redirects.

But this highlights an upcoming issue with redirects which I think we kinda decided punt until later: what do we do with things like keyman.com/khmer --> /keyboards/khmer_angkor? Do we also support keyman.com/en/khmer --> /en/keyboards/khmer_angkor? Do we do this for all redirects or a subset or none?

I am unsure.

mcdurdin · 2026-04-07T14:14:39Z

-      // Fallback to 'en'
-      // TODO-I18N-URL-SCHEME: integrate with Locale.php
-      $fields->lang = isset($_REQUEST['lang']) ? $_REQUEST['lang'] : 'en';


Why remove this? We'll need something like this throughout

ah, I got mixed up thinking the new .htaccess rules would handle the language tag.

So we want to keep $fields->lang for Foot, Menu?

Yes, we'll want to keep those fields but they'll need to be extracted from the URL. I think we'll be able to parse the URL as it should be the first path component, rather than using URL rewriting to append a lang parameter?

mcdurdin · 2026-04-07T14:15:05Z

 ## Links to Other Test Pages

-[/go links](./go)
+[/go links](/_test/go)


Why this change?

The CI link checker test was failing
https://github.com/keymanapp/keyman.com/actions/runs/24058950224/job/70171010949#step:7:18

I don't quite understand it, but the CI link checker would treat these links as:

Getting links from: http://localhost:8053/_test ├─BROKEN─ http://localhost:8053/go (HTTP_403) ├─BROKEN─ http://localhost:8053/language-landing (HTTP_404) ├─BROKEN─ http://localhost:8053/legacy (HTTP_404) ├─BROKEN─ http://localhost:8053/well-known (HTTP_404) Error: Process completed with exit code 1.

This means that the rule which appends a / in a redirect for index.md is missing or out of order; we'll need that.

/_test should redirect to /_test/ because it is a folder.

alongside the rules that strip .php and .md suffix and deal with index filename:

/_test/index.php -> /_test/index

/_test/index.md -> /_test/index

/_test/index -> /_test/

k, still troubleshooting this one.
Will get back to this after Songkran break!

aha, {DOCUMENT_ROOT} needed to be %{DOCUMENT_ROOT}

fixed in 88769e9 along with

cleaning up links in _test

cleaning up unncessary \/ to / in .htaccess

Co-authored-by: Marc Durdin <marc@durdin.net>

darcywong00 · 2026-04-08T03:43:45Z

-            <a href="/<?=$fields->lang?>/about/"><img id="sil-logo" src="<?php echo ImageRandomizer::randomizer(); ?>" width="50%" alt='SIL' /></a>
-            <p>Created by <a href="/<?=$fields->lang?>/about/">SIL Global</a></p>
+            <a href="/about/"><img id="sil-logo" src="<?php echo ImageRandomizer::randomizer(); ?>" width="50%" alt='SIL' /></a>
+            <p>Created by <a href="/about/">SIL Global</a></p>


btw, why doesn't about SIL Global go to https://global.sil.org/about/ ?

Yeah, probably should!

Handled in #711

darcywong00 · 2026-04-21T00:31:11Z

 </p>
 <p>
-    <span class="red">A.</span> Yes, you can find the links to download Keyman Desktop 7.1 and other previous releases <a href="../archive/downloads.php">here</a>.
+    <span class="red">A.</span> Yes, you can find the links to download Keyman Desktop 7.1 and other previous releases <a href="../downloads/archive">here</a>.


This link is cleaned up

darcywong00 added 4 commits March 26, 2026 14:46

fix: .htaccess for including <lang> in the URL

6f8fdae

* From rubber-ducky with MD

fix: more rewrites involving _content

863f677

fix: Add lang to Head.php

d98b236

fix: redirects to currentlang

f4d6d99

darcywong00 added this to the A19S26 milestone Mar 31, 2026

darcywong00 requested a review from mcdurdin March 31, 2026 03:39

keyman-status added this to Keyman Mar 31, 2026

github-actions Bot added the fix label Mar 31, 2026

keymanapp-test-bot Bot added the epic-i18n-url-scheme label Mar 31, 2026

github-project-automation Bot moved this to Todo in Keyman Mar 31, 2026

darcywong00 added 2 commits March 31, 2026 14:26

fix: remove .php from links

91d69b5

tweak regex

cd9fd45

darcywong00 commented Apr 1, 2026

View reviewed changes

Comment thread .htaccess Outdated

darcywong00 added 7 commits April 1, 2026 13:16

Merge branch 'epic/i18n-url-scheme' into fix/lang/htaccess

8b3f67e

fix 404

a0f3d86

fix en routing

3804817

fix: Handle _control, go, and _test

839fb40

* These folders don't use _content

refactor: reorder .htaccess

1583b34

1. remove .php / .md 2. redirects before rewrites 3. rewrite locale to lang= parameter 4. final cleanup

chore: remove old root rule

7ca0e01

fix: downloads/releases paths

57ad35d

darcywong00 marked this pull request as draft April 2, 2026 08:49

darcywong00 added 2 commits April 2, 2026 16:00

fix: keyboard rewrites

37273da

chore: more cleanup

95bbf29

darcywong00 marked this pull request as ready for review April 6, 2026 01:21

fix /archive/downloads redirect

bf9897e

darcywong00 force-pushed the fix/lang/htaccess branch from 7a87423 to bf9897e Compare April 6, 2026 02:16

darcywong00 added 3 commits April 6, 2026 09:36

fix: keyboards/download query

7634f84

fix /contact/exception

93bad37

also cleaned up test pages

fix menu link to "Help and Documentation"

53ba79a

darcywong00 added 7 commits April 6, 2026 10:58

chore: cleanup more _test paths

35f00a4

revert $fields->lang in template links

3822271

fix keyboard landing page links

a92ac18

fix more landing links

7965b0a

try to fix more keyboard landing links

5c1970b

fix: handle assets

be580bd

fix ios links so they can be relative

224561f

darcywong00 commented Apr 7, 2026

View reviewed changes

darcywong00 added 4 commits April 7, 2026 07:59

revert _test/index.md changes

948550f

fix: Use absolute paths for _test/ page

b37b468

fix: re-enable 404 pages

5dd6beb

fixup cdn asset links

11c3a70

mcdurdin requested changes Apr 7, 2026

View reviewed changes

darcywong00 and others added 6 commits April 8, 2026 08:59

Apply suggestions from code review

2440249

Co-authored-by: Marc Durdin <marc@durdin.net>

fix: Convert android/iOS app links to root level redirect

7a434a0

fix some links per review comments

2211c08

fix: Move cdn rule to section with _control, go, _test

c44bd72

fix: Make windows archive link relative

5531862

fix RewriteCond for asset

490a0f5

darcywong00 commented Apr 8, 2026

View reviewed changes

Revert fields->lang to header and footer

3b78d44

keyman-server modified the milestones: A19S26, A19S27 Apr 14, 2026

darcywong00 commented Apr 21, 2026

View reviewed changes

fix slashes in .htaccess

88769e9

mcdurdin reviewed Apr 21, 2026

View reviewed changes

Comment thread _includes/2020/templates/Menu.php Outdated

Apply suggestion from @darcywong00

7566f6b

darcywong00 mentioned this pull request Apr 21, 2026

chore: Update links about SIL Global #711

Open

	<span class="red">A.</span> Yes, you can find the links to download Keyman Desktop 7.1 and other previous releases <a href="/archive/downloads">here</a>.
	<span class="red">A.</span> Yes, you can find the links to download Keyman Desktop 7.1 and other previous releases <a href="../archive/downloads">here</a>.

	# Redirect /archive/downloads.php"
	RewriteRule "^archive/downloads(.php)?$" "/downloads/archive/" [NC,R=301,QSA]

Uh oh!

Conversation

darcywong00 commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

keymanapp-test-bot Bot commented Mar 31, 2026

User Test Results

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

darcywong00 commented Mar 31, 2026 •

edited

Loading