feat: show keyboard status in Details#802
Open
mcdurdin wants to merge 1 commit into
Open
Conversation
Add a keyboard status field to the details, and an explanation. Extend the UI with a tooltip explanation of the field, exposed with dotted underline. Note that the tooltip will not be accessible on touch devices at this time (both this and other tooltips on the page are areas for future enhancement). Fixes: #566 Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
sgschantz
reviewed
Jun 24, 2026
sgschantz
left a comment
sgschantz
left a comment
There was a problem hiding this comment.
Looks good to me, but can you break out the logic for serring the status property into a separate function instead of making that already large function even larger?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a keyboard status field to the details, and an explanation. Extend the UI with a tooltip explanation of the field, exposed with dotted underline. Note that the tooltip will not be accessible on touch devices at this time (both this and other tooltips on the page are areas for future enhancement).
Fixes: #566
Test-bot: skip