refactor(web): rework applied-suggestion tracking 🚂#15727
Draft
jahorton wants to merge 14 commits intofeat/web/test-quotient-specialized-splitsfrom
Draft
refactor(web): rework applied-suggestion tracking 🚂#15727jahorton wants to merge 14 commits intofeat/web/test-quotient-specialized-splitsfrom
jahorton wants to merge 14 commits intofeat/web/test-quotient-specialized-splitsfrom
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
Bot
changed the title
jahorton
force-pushed
the
refactor/web/realign-tokenization
branch
from
7e07e77 to
41beca3
Compare
…nd of a correction path Build-bot: skip build:web Test-bot: skip
Per the search quotient graph documentation, we should no longer have one node type handle all edit operation types. Our current ("legacy") implementation and unit tests are most tailored for the needs of 'substitution' edit types, so this PR starts there.
Build-bot: skip build:web
Test-bot: skip
Build-bot: skip build:web Test-bot: skip
…rd parent results
Also extends the test-helper with an extra check needed for 'insert' edit cases, to validate parent-result forwarding
…ion-edit search-graph edges Build-bot: skip build:web Test-bot: skip
…d spur types Build-bot: skip build:web Test-bot: skip
Build-bot: skip build:web Test-bot: skip
Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
refactor/web/applied-suggestion-tracking
branch
from
1a4c02b to
2239c84
Compare
jahorton
changed the base branch from
refactor/web/realign-tokenization
to
feat/web/test-quotient-specialized-splits
jahorton
force-pushed
the
feat/web/test-quotient-specialized-splits
branch
2 times, most recently
from
6ed7e79 to
8fb9786
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build-bot: skip build:web
Test-bot: skip