feat(android): design improvement for settings, add dark mode and tool menu by Mengchou97 · Pull Request #15827 · keymanapp/keyman

Mengchou97 · 2026-04-08T07:51:07Z

Team: @Mengchou97, @seyhachhorn-dev, @phyphy-svg, @kongchanlina, @seanvisal69-ux, and @minanlynna-code.

Test-bot: skip
Fixes: #12718

Updated:

Fix text layout and organize text structure, images, mention team members.

Side panel changes

change section title: the about section has been changed to help section
renamed keyman for android to user guide: resolved the confusing option name
added the update keyboards to help section

added current keyboard to Setup: Display the selected keyboard

added subtitles to side panel’s options
added the space bar caption back to side panel
remove the more setting option: everything from the setting had been moved out
changed haptic feedback to show “get started” on startup
renamed all side panel’s options to their original name

changed each option’s icon to be unique

adjusted the alignment of the right icons and added right arrows to some options

Dark mode changes

added an appearance mode option to side panel
Introduced an Appearance Mode Toggle in the side panel to allow users to switch between light, dark mode, or system default.

Splash Screen Update: Applied Light Keyman for improved visual consistency during app launch in dark mode.
Added support for dark mode styling across all components.

Main page changes

added the floating toolbar button to the main interface
moved the share, text size, and trash to toolbar option
added animation to the floating button

Final looks

Light mode

Dark mode

…into dark-mode-on-side-panel

…e sidebar

…e screen

…on-side-panel

keymanapp-test-bot · 2026-04-08T07:51:14Z

User Test Results

Test specification and instructions

User tests are not required

keyman-server · 2026-04-08T07:52:13Z

This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR.

mcdurdin · 2026-04-08T12:05:21Z

សូមអរគុណច្រើន! Thank you for your fantastic contribution! I look forward to reviewing this next week with our team and we will provide feedback and comments then.

mcdurdin

Thank you for this very nice changeset.

I do have a lot of suggestions for the code, so please work through those suggestions -- some of them are applicable throughout, for example avoiding whitespace-only changes.

We have also completed a design review this morning, which is available in a Google Doc: https://docs.google.com/document/d/1ipuuyOGDDC62Wi4mhdkO1SO75vhQCkziybtvb7niAUg/edit?usp=sharing

🩷 Overall we are really happy with how this looks and the improvement to the Keyman user experience. Well done! 🩷

Please feel free to ask questions if anything is unclear!

mcdurdin · 2026-04-13T08:06:53Z

+    implementation 'com.google.android.gms:play-services-maps3d:0.2.0'
+    //implementation 'com.google.android.gms:play-services-maps:19.0.0'


What is this for? We shouldn't need this in Keyman

Suggested change

implementation 'com.google.android.gms:play-services-maps3d:0.2.0'

//implementation 'com.google.android.gms:play-services-maps:19.0.0'

mcdurdin · 2026-04-13T08:07:11Z

    defaultConfig {
        applicationId "com.tavultesoft.kmapro"
-        minSdkVersion 21
+        minSdkVersion 23


We would prefer not to update the minSdkVersion. Is there a reason why it has changed?

mcdurdin · 2026-04-13T08:07:48Z

  https://support.google.com/googleplay/android-developer/answer/9214102#
  <uses-permission android:name="android.permission.QUERY_ALL_PACKAGES" /> -->
  <application
+    android:name=".MyApp"


Suggested change

android:name=".MyApp"

We're not sure why you've added this name? It's not the name of the app, so if you need it to link to "MyApp.java" we need to rename it to something appropriate.

mcdurdin · 2026-04-13T08:08:10Z

+<!--      <activity-->
+<!--          android:name=".SplashScreenActivity"-->
+<!--          android:exported="true"-->
+<!--          android:label="@string/app_name"-->
+<!--          android:resizeableActivity="false"-->
+<!--          android:theme="@style/AppTheme_BrandedLunch"-->
+<!--          >-->


Suggested change

mcdurdin · 2026-04-13T08:08:23Z

      android:label="@string/app_name"
      android:resizeableActivity="false"
-      android:theme="@style/AppTheme.BrandedLaunch">
+        android:theme="@style/Theme.App.Starting">


Suggested change

android:theme="@style/Theme.App.Starting">

android:theme="@style/Theme.App.Starting">

mcdurdin · 2026-04-13T09:05:24Z

+    keyboardToolbarContainer = findViewById(R.id.keyboardToolbarContainer);
+
+    if (keyboardToolbarToggleButton == null || keyboardToolbarContainer == null) {
+      return;


Can this ever happen? Do we need to report an error if this is happening?

An error guard like this is nice to have, but it can hide a more serious issue. So we need to decide if this needs to be reported as an error to Keyman team through Sentry.

mcdurdin · 2026-04-13T09:07:36Z

+    keyboardToolbarToggleButton.setOnClickListener(v -> setKeyboardToolbarExpanded(!isKeyboardToolbarExpanded, true));
+
+    View shareButton = findViewById(R.id.keyboardToolbarShareButton);
+    if (shareButton != null) {


Do we need to report an error if shareButton == null here (and same for other buttons)?

mcdurdin · 2026-04-13T09:10:17Z

+  private int dpToPx(int dp) {
+    float density = getResources().getDisplayMetrics().density;
+    return Math.round(dp * density);
  }


Is this really needed? Should we be working either exclusively in dp or exclusively in px? I see that it is used only in two places with integer constants in updateKeyboardToolbarPosition:

int keyboardTopOffset = KMManager.getKeyboardHeight(this) + KMManager.getBannerHeight(this) + dpToPx(12); updateBottomMargin(keyboardToolbarToggleButton, keyboardTopOffset); updateBottomMargin(keyboardToolbarContainer, dpToPx(8));

mcdurdin · 2026-04-13T09:11:49Z

    });

-    dialogBuilder.show();
+    // dialogBuilder.show(); no dialog


Suggested change

// dialogBuilder.show(); no dialog

mcdurdin · 2026-04-13T09:13:48Z

+    setDrawerItemSubtitle(navigationView, R.id.nav_help,
+        getString(R.string.drawer_subtitle_about));


The subtitle id does not match the primary title id

mcdurdin · 2026-04-13T09:23:11Z

Note: I committed a couple of minor changes to get the project to build and removed some unnecessary changes from other parts of Keyman. Please pull these changes locally before updating.

Mengchou97 · 2026-04-27T15:23:22Z

Thank you so much for the feedback! I’ve updated the code based on your suggestions and made several improvements.

I’ll go through the rest of the comments and continue refining things as much as I can.

I’ve also added a Google Doc with a summary of the changes here: https://docs.google.com/document/d/1uJisJ9qhv7sipawU6dWb4HGHbQeoMnKriB50QkU1sxM/edit?usp=sharing .

Please let me know if you have any further suggestions!

memaynor and others added 30 commits March 16, 2026 15:22

testing message

b1575b4

90% of Dark Mode

b0399d3

updated-right-panel-to-origin-without-merging

6f31744

change section title

776b565

changed splash_screen logo

cdc4c0b

Merge branch 'side-panel-prod' of https://github.com/memaynor/keyman …

bb8b8f0

…into dark-mode-on-side-panel

dark-mode-on-side-panel

92c795c

fixed the conflict sidebr button

dc70f68

added subtitle

5f377c7

updated sidebar with pr

7b0ec6e

fixed sidebar layout and remove redundant code

9f7d1b1

added the floating button for toolbar and final touches on icon in th…

25617f8

…e sidebar

fixed the button close function

52290ae

adjusted the width of the sidebar to always wrap-content at 80% of th…

244cec4

…e screen

Splash Screen's Appearance Mode

e373dbd

Merge remote-tracking branch 'origin/side-panel-prod' into dark-mode-…

25b90dd

…on-side-panel

dark-mode-on-new-updated-ui

717889a

nothing

66a01ca

nothing

d4af11d

fixing status bar color

c67f319

fixing status bar

409b9b0

fixing status bar

86caca9

minor adjustment to the string and the name of the side panel

5335625

updated the set keyman as default option function

45590e5

finally finished the set keyman as default keyboard

a447e18

updated the update keyboard function

97fad55

Merge branch 'keymanapp:master' into main

2834c12

Update README.md

bf5164d

merge from main

d4b86bf

updated string for osk

e281b9a

keymanapp-test-bot Bot added this to the A19S26 milestone Apr 8, 2026

keymanapp-test-bot Bot removed the user-test-missing User tests have not yet been defined for the PR label Apr 8, 2026

Meng-Heng requested review from darcywong00, jahorton and mcdurdin April 8, 2026 08:52

Meng-Heng changed the title ~~Feat/dark mode and settings~~ feat(android): design improvement for settings, add dark mode and tool menu Apr 8, 2026

Meng-Heng added the android/ label Apr 8, 2026

Meng-Heng mentioned this pull request Apr 8, 2026

feat(android): dark mode support #12718

Open

mcdurdin self-assigned this Apr 8, 2026

mcdurdin added the feat label Apr 8, 2026

mcdurdin added 2 commits April 13, 2026 08:33

chore: restore files

3c11eae

chore(android): uncomment main_text_color

1c175f0

mcdurdin requested changes Apr 13, 2026

View reviewed changes

This comment was marked as duplicate.

Sign in to view

keyman-server modified the milestones: A19S26, A19S27 Apr 14, 2026

Mengchou97 and others added 7 commits April 20, 2026 10:26

fixed the pull request problem

fe8861d

replace icon

d3a76b8

updated icons for side panel and titlebar

32b383f

completed adding separator to side-panel using group

4d48850

updated the hamburger icon in the titlebar to switch between theme

5f8c38e

Update dark mode handling for Chrome WebView layout

a3781a8

updated the font color once in dark mode

9489cf1

keyman-server modified the milestones: A19S27, A19S28 Apr 24, 2026

		implementation 'com.google.android.gms:play-services-maps3d:0.2.0'
		//implementation 'com.google.android.gms:play-services-maps:19.0.0'

	android:theme="@style/Theme.App.Starting">
	android:theme="@style/Theme.App.Starting">

		setDrawerItemSubtitle(navigationView, R.id.nav_help,
		getString(R.string.drawer_subtitle_about));

Uh oh!

Conversation

Mengchou97 commented Apr 8, 2026 • edited by Meng-Heng Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Side panel changes

Dark mode changes

Main page changes

Final looks

Light mode

Dark mode

Uh oh!

keymanapp-test-bot Bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User Test Results

Uh oh!

keyman-server commented Apr 8, 2026

Uh oh!

mcdurdin commented Apr 8, 2026

Uh oh!

mcdurdin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as duplicate.

Uh oh!

mcdurdin commented Apr 13, 2026

Uh oh!

Mengchou97 commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Mengchou97 commented Apr 8, 2026 •

edited by Meng-Heng

Loading

keymanapp-test-bot Bot commented Apr 8, 2026 •

edited

Loading

Mengchou97 commented Apr 27, 2026 •

edited

Loading