chore(common): cleanup optionals in ldml keyboard reader#15865
Open
chore(common): cleanup optionals in ldml keyboard reader#15865
Conversation
`boxArrays` had some optional chaining that was either not needed, and/or was used in an inappropriate context, for example within the iterable argument to a `for` statement, which would have caused an "not iterable" error if it ever actually resolved to `undefined`. This should have no material impact on the code, but helps to clarify code readability. Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
boxArrayshad some optional chaining that was either not needed, and/or was used in an inappropriate context, for example within the iterable argument to aforstatement, which would have caused an "not iterable" error if it ever actually resolved toundefined.This should have no material impact on the code, but helps to clarify code readability.
I uncovered this while reviewing #12564.
Test-bot: skip