feat(web): get list of store names from stores defined in core 🎼#15870
Open
ermshiperete wants to merge 1 commit intoepic/web-corefrom
Open
feat(web): get list of store names from stores defined in core 🎼#15870ermshiperete wants to merge 1 commit intoepic/web-corefrom
ermshiperete wants to merge 1 commit intoepic/web-corefrom
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
Bot
changed the title
This implements `CoreKeyboardInterface.loadSerializedOptions` by getting the list of all variable store names from Core and then trying to load these. Also change `VariableStoreSerializer.loadStore` signature so that it can return `undefined`. This allows to return only those options from `loadSerializedOptions` that have a non-default value, i.e. were serialized before. Build-bot: skip build:web Test-bot: skip
ermshiperete
force-pushed
the
feat/web/loadSerializedOpts
branch
from
10ee3c3 to
35ea65c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements
CoreKeyboardInterface.loadSerializedOptionsby getting the list of all variable store names from Core and then trying to load these.Also change
VariableStoreSerializer.loadStoresignature so that it can returnundefined. This allows to return only those options fromloadSerializedOptionsthat have a non-default value, i.e. were serialized before.Follow-up-of: #15470
Build-bot: skip build:web
Test-bot: skip