-
Notifications
You must be signed in to change notification settings - Fork 166
chore: add Playroom deployment #4580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Storybook staging is available at https://kiwicom-orbit-sarka-playroom-deploy.surge.sh |
|
Size Change: +1 B (0%) Total Size: 459 kB
ℹ️ View Unchanged
|
e65e766 to
abe94ef
Compare
05fc766 to
6a93376
Compare
7385644 to
e22aa30
Compare
|
Playroom staging is available at https://kiwicom-orbit-playroom-sarka-playroom-deploy.surge.sh |
96fcd89 to
5082c99
Compare
5b21cd1 to
38afda6
Compare
|
Storybook staging is available at https://kiwicom-orbit-sarka-playroom-deploy.surge.sh |
68f5433 to
8317a6d
Compare
|
Storybook staging is available at https://kiwicom-orbit-sarka-playroom-deploy.surge.sh |
eb1a8cd to
f19a675
Compare
c175634 to
85ed462
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Key Issues
The PR review highlights the need for type checking on the children prop to prevent runtime errors when it is invoked as a function without ensuring it is a function type.
This Pull Request meets the following criteria:
For new components:
d.tsfiles and are exported inindex.d.ts✨
Description by Callstackai
This PR adds deployment configurations for Playroom and updates various components and documentation to reflect the new Playroom feature.
Diagrams of code changes
sequenceDiagram participant CI as CI/CD Pipeline participant Build as Build Process participant Deploy as Deployment participant UI as User Interface CI->>Build: Add Playroom build steps Note over Build: yarn components build:playroom Note over Build: yarn components build:storybook Build->>Deploy: Deploy to Surge Note over Deploy: Generate version tag Note over Deploy: Create Playroom domain Deploy->>UI: Add Playroom links Note over UI: Add to Navbar Note over UI: Add to Footer Note over UI: Update documentation Deploy-->>CI: Post deployment info Note over Deploy: Add Playroom URL to PR comments Note over Deploy: Include in changelog updatesFiles Changed
This PR includes files in programming languages that we currently do not support. We have not reviewed files with the extensions
.yml,.mdx,.md,.mjs. See list of supported languages.