Skip to content

Conversation

@gauron99
Copy link
Contributor

No description provided.

@knative-prow
Copy link

knative-prow bot commented Nov 22, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 22, 2025
@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

❌ Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.27%. Comparing base (5d86d20) to head (31ad9d7).
⚠️ Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
pkg/builders/buildpacks/builder.go 66.66% 3 Missing and 3 partials ⚠️

❗ There is a different number of reports uploaded between BASE (5d86d20) and HEAD (31ad9d7). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (5d86d20) HEAD (31ad9d7)
unit ubuntu-24.04-arm 1 0
unit ubuntu-latest 1 0
unit macos-14 1 0
unit macos-latest 1 0
unit windows-latest 1 0
integration 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3237       +/-   ##
===========================================
- Coverage   54.57%   42.27%   -12.30%     
===========================================
  Files         162      138       -24     
  Lines       19216    13568     -5648     
===========================================
- Hits        10487     5736     -4751     
+ Misses       7686     6889      -797     
+ Partials     1043      943      -100     
Flag Coverage Δ
e2e 39.73% <68.00%> (+0.04%) ⬆️
e2e go 35.67% <68.00%> (+0.05%) ⬆️
e2e node 30.97% <28.00%> (-0.02%) ⬇️
e2e python 35.22% <20.00%> (-0.13%) ⬇️
e2e quarkus 31.13% <28.00%> (-0.02%) ⬇️
e2e rust 30.55% <28.00%> (-0.01%) ⬇️
e2e springboot 30.60% <28.00%> (-0.01%) ⬇️
e2e typescript 31.11% <28.00%> (+0.01%) ⬆️
integration ?
unit macos-14 ?
unit macos-latest ?
unit ubuntu-24.04-arm ?
unit ubuntu-latest ?
unit windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99 gauron99 force-pushed the push-ywknoytomzzx branch 2 times, most recently from 73ce011 to f310b09 Compare November 22, 2025 15:36
@gauron99 gauron99 changed the title duplicated [DNM][WIP] duplicated func-util test Nov 22, 2025
@gauron99 gauron99 force-pushed the push-ywknoytomzzx branch 4 times, most recently from 5295030 to 8161b74 Compare November 24, 2025 07:04
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 24, 2025
@gauron99 gauron99 force-pushed the push-ywknoytomzzx branch 2 times, most recently from e6a1586 to cc15a7d Compare November 24, 2025 13:13
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 24, 2025
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 6, 2025
@knative-prow-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants