Update HTTP links to HTTPS in docs and source comments#3617
Update HTTP links to HTTPS in docs and source comments#3617Ankitsinghsisodya wants to merge 4 commits intoknative:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ankitsinghsisodya The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
Updates documentation/source-comment links from HTTP to HTTPS to align with security best practices and address issue #3616.
Changes:
- Updated
ce-sourceexample URLs in the Rust CloudEvents template README tohttps://cloudevents.io. - Updated the Kubernetes documentation link in the
EmptyDirvolume comment to HTTPS.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| templates/rust/cloudevents/README.md | Switches ce-source example values to HTTPS. |
| pkg/functions/function_volumes.go | Switches the Kubernetes “More info” comment link to HTTPS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Replace insecure HTTP URLs with HTTPS in a source comment and Rust cloudevents README examples. Both kubernetes.io and cloudevents.io support HTTPS.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Re-runs go generate to produce zz_filesystem_generated.go that includes both the upstream python cloudevents update and our http-to-https fixes.
591453c to
7a8c51e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3617 +/- ##
=======================================
Coverage 56.30% 56.30%
=======================================
Files 180 180
Lines 20549 20549
=======================================
+ Hits 11570 11571 +1
+ Misses 7778 7777 -1
Partials 1201 1201
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Changes
kubernetes.iocomment link inpkg/functions/function_volumes.goto use HTTPScloudevents.ioexample URLs intemplates/rust/cloudevents/README.mdto use HTTPS/kind cleanup
Fixes #3616
Release Note
Docs