Skip to content

Update HTTP links to HTTPS in docs and source comments#3617

Open
Ankitsinghsisodya wants to merge 4 commits intoknative:mainfrom
Ankitsinghsisodya:fix/http-to-https-links
Open

Update HTTP links to HTTPS in docs and source comments#3617
Ankitsinghsisodya wants to merge 4 commits intoknative:mainfrom
Ankitsinghsisodya:fix/http-to-https-links

Conversation

@Ankitsinghsisodya
Copy link
Copy Markdown
Contributor

@Ankitsinghsisodya Ankitsinghsisodya commented Apr 17, 2026

Changes

  • Update kubernetes.io comment link in pkg/functions/function_volumes.go to use HTTPS
  • Update cloudevents.io example URLs in templates/rust/cloudevents/README.md to use HTTPS

/kind cleanup

Fixes #3616

Release Note


Docs


Copilot AI review requested due to automatic review settings April 17, 2026 06:59
@knative-prow knative-prow bot added the kind/cleanup Cleanup label Apr 17, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 17, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ankitsinghsisodya
Once this PR has been reviewed and has the lgtm label, please assign matzew for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from dsimansk and jrangelramos April 17, 2026 06:59
@knative-prow knative-prow bot added the size/XS 🤖 PR changes 0-9 lines, ignoring generated files. label Apr 17, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 17, 2026

Hi @Ankitsinghsisodya. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the needs-ok-to-test 🤖 Needs an org member to approve testing label Apr 17, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates documentation/source-comment links from HTTP to HTTPS to align with security best practices and address issue #3616.

Changes:

  • Updated ce-source example URLs in the Rust CloudEvents template README to https://cloudevents.io.
  • Updated the Kubernetes documentation link in the EmptyDir volume comment to HTTPS.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
templates/rust/cloudevents/README.md Switches ce-source example values to HTTPS.
pkg/functions/function_volumes.go Switches the Kubernetes “More info” comment link to HTTPS.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/functions/function_volumes.go Outdated
@knative-prow-robot knative-prow-robot added the needs-rebase Cannot be merged due to conflicts with HEAD. label Apr 17, 2026
Ankitsinghsisodya and others added 3 commits April 17, 2026 14:05
Replace insecure HTTP URLs with HTTPS in a source comment
and Rust cloudevents README examples. Both kubernetes.io
and cloudevents.io support HTTPS.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Re-runs go generate to produce zz_filesystem_generated.go that includes
both the upstream python cloudevents update and our http-to-https fixes.
@Ankitsinghsisodya Ankitsinghsisodya force-pushed the fix/http-to-https-links branch from 591453c to 7a8c51e Compare April 17, 2026 08:36
@knative-prow-robot knative-prow-robot removed the needs-rebase Cannot be merged due to conflicts with HEAD. label Apr 17, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.30%. Comparing base (02faab0) to head (724a5c8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3617   +/-   ##
=======================================
  Coverage   56.30%   56.30%           
=======================================
  Files         180      180           
  Lines       20549    20549           
=======================================
+ Hits        11570    11571    +1     
+ Misses       7778     7777    -1     
  Partials     1201     1201           
Flag Coverage Δ
e2e 36.20% <ø> (-0.02%) ⬇️
e2e go 32.86% <ø> (ø)
e2e node 28.62% <ø> (ø)
e2e python 33.23% <ø> (ø)
e2e quarkus 28.76% <ø> (ø)
e2e rust 28.18% <ø> (+0.06%) ⬆️
e2e springboot 26.65% <ø> (ø)
e2e typescript 28.75% <ø> (+0.02%) ⬆️
e2e-config-ci 18.08% <ø> (ø)
integration 17.51% <ø> (+0.03%) ⬆️
unit macos-14 43.35% <ø> (+<0.01%) ⬆️
unit macos-latest 43.35% <ø> (ø)
unit ubuntu-24.04-arm 43.55% <ø> (ø)
unit ubuntu-latest 44.23% <ø> (ø)
unit windows-latest 43.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Cleanup needs-ok-to-test 🤖 Needs an org member to approve testing size/XS 🤖 PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: update HTTP links to HTTPS

3 participants