fix(workflow): use product envs in task filters#4653
Merged
lilianzhu merged 1 commit intokoderover:mainfrom Apr 27, 2026
Merged
fix(workflow): use product envs in task filters#4653lilianzhu merged 1 commit intokoderover:mainfrom
lilianzhu merged 1 commit intokoderover:mainfrom
Conversation
05ddfae to
373842f
Compare
PetrusZ
reviewed
Apr 24, 2026
373842f to
b78d5d6
Compare
Signed-off-by: huanghongbo <huanghongbo@koderover.com>
b78d5d6 to
c12aec0
Compare
PetrusZ
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
productcollection instead of workflow task historyproductBackground
The workflow execution record page calls
GET /api/aslan/workflow/v4/workflowtask/filter/workflow/:name?queryType=envName&jobName=...to fetch env filter options. The correct data source for the env list is theproductcollection rather than workflow task history. This change aligns the filter options with the current env list stored inproduct.Verification
/usr/local/go/bin/go build ./pkg/microservice/aslan/core/workflow/service/workflow/usr/local/go/bin/go test -vet=off ./pkg/microservice/aslan/core/workflow/service/workflowgo teststill hits pre-existing vet issues in this package unrelated to this changeThis change is