Skip to content

fix(testing): validate generated workflow job names#4655

Open
huanghongbo-hhb wants to merge 1 commit intokoderover:mainfrom
huanghongbo-hhb:fix/testing-job-name-validation
Open

fix(testing): validate generated workflow job names#4655
huanghongbo-hhb wants to merge 1 commit intokoderover:mainfrom
huanghongbo-hhb:fix/testing-job-name-validation

Conversation

@huanghongbo-hhb
Copy link
Copy Markdown
Contributor

@huanghongbo-hhb huanghongbo-hhb commented Apr 24, 2026

Summary:

  • validate testing and scanning module names before create/update so they can generate valid workflow job names
  • move generated workflow job name helpers into core/common/util for reuse
  • reuse the same helpers when generating standalone testing/scanning workflows to keep behavior consistent

Background:
Testing and scanning modules could previously be created with names that were valid in the UI but invalid after being transformed into workflow job names. This caused standalone execution to fail later during workflow linting with job-name validation errors.

Verification:

  • /usr/local/go/bin/go test -vet=off ./pkg/microservice/aslan/core/workflow/testing/service ./pkg/microservice/aslan/core/common/util

This change is Reviewable

Signed-off-by: huanghongbo <huanghongbo@koderover.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant