-
Notifications
You must be signed in to change notification settings - Fork 0
Finish reliability showcase quality gates #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,19 @@ | ||
| package transactions; | ||
|
|
||
| import lombok.Getter; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.Collections; | ||
| import java.util.List; | ||
|
|
||
| @Getter | ||
| final class ValidationResult { | ||
| private final List<TransactionStatus> transactions; | ||
|
|
||
| public ValidationResult(List<TransactionStatus> transactions) { | ||
| this.transactions = List.copyOf(transactions); | ||
| record ValidationResult(List<TransactionStatus> transactions) { | ||
| ValidationResult { | ||
| transactions = List.copyOf(transactions); | ||
| } | ||
|
|
||
| public static ValidationResult empty() { | ||
| return new ValidationResult(List.of()); | ||
| } | ||
|
|
||
| public List<TransactionStatus> getTransactions() { | ||
| return Collections.unmodifiableList(new ArrayList<>(transactions)); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
104 changes: 104 additions & 0 deletions
104
src/test/java/transactions/InMemoryValidationServicePropertyTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| package transactions; | ||
|
|
||
| import net.jqwik.api.Arbitraries; | ||
| import net.jqwik.api.Arbitrary; | ||
| import net.jqwik.api.Combinators; | ||
| import net.jqwik.api.ForAll; | ||
| import net.jqwik.api.Property; | ||
| import net.jqwik.api.Provide; | ||
| import net.jqwik.api.Tag; | ||
| import net.jqwik.api.constraints.LongRange; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.Collections; | ||
| import java.util.HashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
|
||
| @Tag("property") | ||
| class InMemoryValidationServicePropertyTest { | ||
| private final ValidationService service = ValidationService.getInstance(); | ||
|
|
||
| @Property(tries = 250) | ||
| void validationIsIndependentOfInputOrder( | ||
| @ForAll("transactionBatches") List<Transaction> transactions, | ||
| @ForAll @LongRange(min = 0, max = 1_000_000) long balance) { | ||
| List<Transaction> reversed = new ArrayList<>(transactions); | ||
| Collections.reverse(reversed); | ||
|
|
||
| List<TransactionStatus> directResult = service.validate(transactions, balance).getTransactions(); | ||
| List<TransactionStatus> reversedResult = service.validate(reversed, balance).getTransactions(); | ||
|
|
||
| assertEquals(directResult, reversedResult); | ||
| assertEquals(transactions.size(), directResult.size()); | ||
| } | ||
|
|
||
| @Property(tries = 250) | ||
| void everyOrderHasOneConsistentStatus( | ||
| @ForAll("transactionBatches") List<Transaction> transactions, | ||
| @ForAll @LongRange(min = 0, max = 1_000_000) long balance) { | ||
| List<TransactionStatus> statuses = service.validate(transactions, balance).getTransactions(); | ||
| Map<Long, Boolean> statusByOrder = new HashMap<>(); | ||
|
|
||
| for (int index = 0; index < statuses.size(); index++) { | ||
| TransactionStatus current = statuses.get(index); | ||
| if (index > 0) { | ||
| assertTrue(statuses.get(index - 1).transaction().id() < current.transaction().id()); | ||
| } | ||
| Boolean existing = statusByOrder.putIfAbsent(current.transaction().orderId(), current.status()); | ||
| if (existing != null) { | ||
| assertEquals(existing, current.status()); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @Property(tries = 150) | ||
| void nonOverflowingWinsAreAlwaysAccepted( | ||
| @ForAll("winOnlyBatches") List<Transaction> transactions, | ||
| @ForAll @LongRange(min = 0, max = 1_000_000) long balance) { | ||
| List<TransactionStatus> statuses = service.validate(transactions, balance).getTransactions(); | ||
|
|
||
| assertEquals(transactions.size(), statuses.size()); | ||
| assertTrue(statuses.stream().allMatch(TransactionStatus::status)); | ||
| } | ||
|
|
||
| @Provide | ||
| Arbitrary<List<Transaction>> transactionBatches() { | ||
| Arbitrary<TransactionSeed> seed = Combinators.combine( | ||
| Arbitraries.longs().between(0, 10), | ||
| Arbitraries.longs().between(0, 10_000), | ||
| Arbitraries.of(TransactionType.values()) | ||
| ).as(TransactionSeed::new); | ||
|
|
||
| return seed.list().ofMaxSize(30) | ||
| .map(InMemoryValidationServicePropertyTest::toTransactions); | ||
| } | ||
|
|
||
| @Provide | ||
| Arbitrary<List<Transaction>> winOnlyBatches() { | ||
| return Arbitraries.longs().between(0, 10_000) | ||
| .list().ofMaxSize(30) | ||
| .map(amounts -> { | ||
| List<Transaction> transactions = new ArrayList<>(amounts.size()); | ||
| for (int index = 0; index < amounts.size(); index++) { | ||
| transactions.add(new Transaction(index + 1L, index % 7L, amounts.get(index), TransactionType.WIN)); | ||
| } | ||
| return transactions; | ||
| }); | ||
| } | ||
|
|
||
| private static List<Transaction> toTransactions(List<TransactionSeed> seeds) { | ||
| List<Transaction> transactions = new ArrayList<>(seeds.size()); | ||
| for (int index = 0; index < seeds.size(); index++) { | ||
| TransactionSeed seed = seeds.get(index); | ||
| transactions.add(new Transaction(index + 1L, seed.orderId(), seed.amount(), seed.type())); | ||
| } | ||
| return transactions; | ||
| } | ||
|
|
||
| private record TransactionSeed(long orderId, long amount, TransactionType type) { | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.