Skip to content

Conversation

@moko-poi
Copy link

@moko-poi moko-poi commented Dec 4, 2025

Summary

Fixed spelling mistakes in the Capacity Buffer feature code.

Changes

  • atrtibutesSetSuccessfullyattributesSetSuccessfully
  • provisioingprovisioning
  • Function name corrections:
    • UpdateBufferStatusToFailedProvisioingUpdateBufferStatusToFailedProvisioning
    • UpdateBufferStatusToSuccessfullyProvisioingUpdateBufferStatusToSuccessfullyProvisioning
  • Comment correction: passespassed

Affected Files

  • cluster-autoscaler/capacitybuffer/common/common.go
  • cluster-autoscaler/processors/capacitybuffer/pod_list_processor.go

No functional changes, purely spelling corrections.

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 4, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @moko-poi. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: moko-poi
Once this PR has been reviewed and has the lgtm label, please assign aleksandra-malinowska for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-area labels Dec 4, 2025
…messages

Fixed spelling errors:
- atrtibutesSetSuccessfully -> attributesSetSuccessfully
- provisioing -> provisioning
- UpdateBufferStatusToFailedProvisioing -> UpdateBufferStatusToFailedProvisioning
- UpdateBufferStatusToSuccessfullyProvisioing -> UpdateBufferStatusToSuccessfullyProvisioning
- passes -> passed (in function comments)
@moko-poi moko-poi force-pushed the fix/spelling-mistakes branch from cda07b3 to c0839a6 Compare December 4, 2025 14:55
@elmiko
Copy link
Contributor

elmiko commented Dec 5, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 5, 2025
@k8s-ci-robot
Copy link
Contributor

@moko-poi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-autoscaling-e2e-ca-build c0839a6 link false /test pull-autoscaling-e2e-ca-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@elmiko
Copy link
Contributor

elmiko commented Dec 5, 2025

it looks like the unit tests also carry this spelling error, https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/capacitybuffer/testutil/testutil.go#L102

which is a real head-scratcher to me, perhaps we should make a constant for this value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants