Makes fixes for v35 changes #8895
Closed
+825
−462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/release-note-label-needed
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gnufied The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/cluster-autoscaler
area/provider/azure
k8s-ci-robot
added
the
size/XXL
gnufied
force-pushed
the
push-debug-35-beta-changes
branch
from
06bcec8 to
2c10d2e
Compare
k8s-ci-robot
added
release-note
gnufied
commented
Dec 5, 2025
| REPO_ROOT="$(git rev-parse --show-toplevel)" | ||
| CODEGEN_PKG=$($GO_CMD list -m -mod=readonly -f "{{.Dir}}" k8s.io/code-generator) | ||
| cd "${CURRENT_DIR}/.." | ||
| cd "${CURRENT_DIR}/../apis" |
Member
Author
There was a problem hiding this comment.
Without this change ./hack/update-codegen.sh fails with:
F1205 11:51:07.357544 1794877 main.go:68] Error: failed making a parser: error(s) in "k8s.io/autoscaler/cluster-autoscaler/apis/provisioningrequest/autoscaling.x-k8s.io/v1":
-: main module (k8s.io/autoscaler/cluster-autoscaler) does not contain package k8s.io/autoscaler/cluster-autoscaler/apis/provisioningrequest/autoscaling.x-k8s.io/v1
error(s) in "k8s.io/autoscaler/cluster-autoscaler/apis/provisioningrequest/autoscaling.x-k8s.io/v1beta1":
-: main module (k8s.io/autoscaler/cluster-autoscaler) does not contain package k8s.io/autoscaler/cluster-autoscaler/apis/provisioningrequest/autoscaling.x-k8s.io/v1beta1
Looks like we may not have ran this script in awhile..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon #8827
And makes additional fixes for fixing unit tests. The fixes just required regenerating the clientset and fakeclients for CRDs we have in autoscaler.