Add security status display for Secure LSL streams #23
+227
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add lsl_security_helper.py to patch pylsl with security methods - Display lock emoji prefix for encrypted streams in tree widget - Show security status (Encrypted/Unencrypted) in status bar - Capture security_enabled and security_fingerprint in stream metadata - Requires liblsl with security API (lsl_get_security_enabled)
Check for native security_enabled/security_fingerprint methods before patching. This maintains compatibility with both old pylsl and the secure-lsl-support branch which adds native support.
- Add local_security_enabled() to check local security credentials - Display error dialog when security config mismatch detected - Show stream names in dialog before blocking connection - Fix float-to-int conversion in paintEvent (PyQt5 compatibility) - Allow users to retry with Update button after fixing credentials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for displaying security status of LSL streams when using Secure LSL (sccn/secureLSL).
Dependencies
This PR requires the secure liblsl library from sccn/secureLSL (currently private, pending review).
Documentation: https://secure-lsl.pages.dev
Note
This is a draft PR. The secureLSL repository is not yet public; this PR is submitted for early review and discussion alongside the main secureLSL proposal for liblsl v2.