feat: adding support for opening datasets using tagged versions through JNI#5873
Draft
hamersaw wants to merge 2 commits intolance-format:mainfrom
Draft
feat: adding support for opening datasets using tagged versions through JNI#5873hamersaw wants to merge 2 commits intolance-format:mainfrom
hamersaw wants to merge 2 commits intolance-format:mainfrom
Conversation
Signed-off-by: Daniel Rammer <hamersaw@protonmail.com>
Signed-off-by: Daniel Rammer <hamersaw@protonmail.com>
majin1102
reviewed
Feb 3, 2026
Contributor
majin1102
left a comment
majin1102
left a comment
There was a problem hiding this comment.
Thanks for working on this. Left one comment. PTAL
| public static class Builder { | ||
|
|
||
| private Optional<Integer> version = Optional.empty(); | ||
| private Optional<String> tag = Optional.empty(); |
Contributor
There was a problem hiding this comment.
Hi Dan, thanks for working on this.
Wondering if we could leverage Ref.java here to enable a complete dataset-opening experience that supports versions, tags, and branches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows setting
tagon JNIReadOptionsand using this to correctly open a dataset.