Skip to content

fix: address review feedback for #2265 (authorAssociation on Issue node)#2

Open
advancedresearcharray wants to merge 1 commit into
lanxevo3:mainfrom
advancedresearcharray:fix/pr-2265-review-feedback
Open

fix: address review feedback for #2265 (authorAssociation on Issue node)#2
advancedresearcharray wants to merge 1 commit into
lanxevo3:mainfrom
advancedresearcharray:fix/pr-2265-review-feedback

Conversation

@advancedresearcharray
Copy link
Copy Markdown

Addresses @SamMorrowDrums's review feedback on upstream PR github#2265.

authorAssociation is a top-level field on the Issue GraphQL node, not on Actor.author.

Changes

Merging this into lanxevo3/main updates the head branch for github/github-mcp-server#2265.

Made with Cursor

Address review feedback from @SamMorrowDrums: authorAssociation is a
top-level field on the Issue GraphQL node, not on Actor.author.

- Add AuthorAssociation to IssueFragment (remove incorrect Author.Association)
- Update fragmentToMinimalIssue() to read the top-level field
- Add author_association to MinimalPullRequest REST path (github#2250)
- Update GraphQL query matchers and test assertions

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant