feat(sheets): typed table I/O, workbook import/export, and lark-sheets skill refresh#1355
Open
xiongyuanwen-byted wants to merge 27 commits into
Open
feat(sheets): typed table I/O, workbook import/export, and lark-sheets skill refresh#1355xiongyuanwen-byted wants to merge 27 commits into
xiongyuanwen-byted wants to merge 27 commits into
Conversation
feat(sheets): add gridline show/hide shortcuts
…tfalls Add targeted guidance to six lark-sheets references to reduce frequent mistakes when editing spreadsheets through the CLI: - write-cells: sanity-check units / dimension conversion / quantity factors before formula writes (formulas can run clean yet be off by a factor); keep derived output off original data columns to avoid clobbering source - core-operations: prefer live formulas for derived values even when "live update" is not explicitly requested; scope rewrite/transform precisely so rows/columns that should stay unchanged are kept 1:1; treat header-stated format rules as checklist items; confirm the artifact file actually exists before finishing; write back bare values from local scripts - visual-standards: apply border/header formatting on explicit request and identify the real header row; keep font size consistent with the source - range-operations: keep total column width within A4 for printing - read-data: dedup/compare long numbers via raw values, not csv formatted display (scientific notation collapses distinct numbers and causes false duplicates) - chart: format date/number axes via source-cell number_format; place charts outside the data area so they do not cover existing data
- Add lark_sheet_table_io.go with +table-put / +table-get and tests - Refactor read-data; extend workbook; register new shortcuts - Sync generated flag defs/schemas (go:embed) from sheet-skill-spec - Sync skill references (write-cells numeric-column guidance, plus read-data / workbook / chart updates)
Quick-ref table (SKILL.md, the first decision point) had no +table-put and gated typed writes on "DataFrame", so a model holding a Counter/list/dict would fall back to +csv-put and silently lose number/date fidelity. - split csv-put row to plain-text values (no numeric/date semantics) - add +table-put row for typed writes into an existing sheet - add +workbook-create --sheets row for create + typed write in one shot - add judgment note: number/amount/date/percent/count -> +table-put (or +workbook-create --sheets when the workbook does not exist yet); plain text -> +csv-put - reframe write-cells scenario row to lead with numeric semantics - point new-table writes at +workbook-create --sheets (one shot) instead of the create-empty-then-table-put two-step Synced from sheet-skill-spec canonical (generate:cli + sync:cli).
Mirror the upstream sheet-skill-spec change removing the "not applicable to local Excel files" tail from the sheets skill and reference descriptions.
Mirror the upstream sheet-skill-spec change removing the "applies to Feishu sheets only" tail from the 14 sheet reference descriptions.
Import a local xlsx/xls/csv as a new spreadsheet by delegating to the shared drive import flow with the target type pinned to sheet. Refactor drive +import to expose ImportParams / ValidateImport / PlanImportDryRun / RunImport (behavior unchanged, existing drive tests still cover it); sheets reuses them. Regenerate flag_defs_gen.go and sync the spec mirror.
Replace +workbook-export's parallel export-task implementation with the shared drive ExportParams/RunExport core (pinned to type=sheet). Drops ~90 lines of duplicated poll/download code; +workbook-export now inherits drive's ctx cancellation, resume-on-timeout, filename sanitize/overwrite, and the full set of export status labels. The output contract aligns with drive's (adds ready/downloaded/doc_type; saved_path preserved). Also normalize an empty drive --output-dir to "." so drive +export behavior is unchanged, and fix the sheets export e2e to call +workbook-export instead of a nonexistent +export.
…ested metric - range-operations: only widen new / overflowing columns; never recompute or shrink the widths of existing columns (any blanket resize, even by 1px, breaks the original visual format) - chart: when the user asks for a share / percentage, the value axis should be a percentage (pie, or stack.percentage on bar/column) rather than raw counts
Replace scoring-framework wording in the examples with plain functional consequences (e.g. "not delivered", "goes stale when the source changes", "breaks the original visual format"), so the references stay agent-facing.
Bring the hand-applied write-cells example in line with the spec-generated reference so the CLI mirror is byte-identical to the canonical source.
docs(sheets): strengthen lark-sheets references for common editing pitfalls
Sync the formula-support wording from sheet-skill-spec (flag-defs, skill references) and update the hand-authored cobra Description and comment for +csv-put. +csv-put evaluates a leading-= cell as a formula via set_range_from_csv; descriptions only, no behavior change.
The chart reference's placement example used non-existent flags --dimension/--start/--end for +dim-insert. The real signature is --position (required) + --count (required); copying the example fails Validate with "--position is required". Replace it with +dim-insert --position V --count 6 (insert 6 columns before V, i.e. after U), aligning with the sheet-structure reference.
Sync three reference-doc corrections from the spec source:
1. chart: label position.row as 0-based (first row = row:0), distinct
from the 1-based row numbers used by A1 ranges and +dim-insert
--position, removing the row-base ambiguity.
2. chart: convert the three runnable examples whose JSON contains a
quoted sheet prefix ('Sheet1'!A1) from inline single-quoted
--properties '{...}' to a stdin heredoc (--properties - <<'JSON').
Inside an inline single-quoted string bash strips the inner quotes
around the sheet name (and splits names with spaces into words),
corrupting the JSON; a quoted heredoc delimiter performs no shell
substitution and preserves it. Adds a short note on the pitfall.
3. filter / filter-view: add the full conditions[].type x compare_type
enum table (text / number / multiValue / color and their respective
compare_type values and values shape), and call out the
equals/notEquals (with s) vs equal/notEqual (no s) gotcha. The docs
previously only showed two values via examples.
The base flag description for +sheet-create's --index omitted the
coordinate base, while its siblings +sheet-move ("Target position
(0-based)") and +sheet-copy already state 0-based. Align the description
so the index base is unambiguous. Synced from the spec source
(flag-defs.json + workbook reference).
docs(sheets): chart / filter / workbook reference corrections
|
|
github-actions
Bot
added
domain/ccm
📝 WalkthroughWalkthroughThis PR adds a typed table protocol (TablePut/TableGet), centralizes Drive export/import into exported helpers, integrates those cores into workbook shortcuts (create/export/import), removes CsvGet's rows-json path, updates CLI flag/schema/dispatch metadata, and adds tests and documentation for the new contracts. ChangesSheets Typed Table Protocol & Workbook Integration
Estimated code review effort 🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@773b93cb102e7781eeb6efbd4299ab60149455bc🧩 Skill updatenpx skills add larksuite/cli#feat/lark-sheets-develop -y -g |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1355 +/- ##
==========================================
+ Coverage 71.79% 71.96% +0.17%
==========================================
Files 690 691 +1
Lines 65596 66121 +525
==========================================
+ Hits 47094 47584 +490
+ Misses 14845 14835 -10
- Partials 3657 3702 +45 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
shortcuts/sheets/data/flag-schemas.json (1)
17-68:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd gridline shortcuts to
+batch-update.operations.shortcutenum.
+sheet-show-gridlineand+sheet-hide-gridlineare now batchable in dispatch/tests, but they’re missing from the schema enum, so schema-validated+batch-updatepayloads can be rejected incorrectly.Suggested fix
"enum": [ "+cells-set", "+cells-set-style", "+cells-clear", "+cells-merge", "+cells-unmerge", "+cells-replace", "+csv-put", "+dropdown-set", "+dim-insert", "+dim-delete", "+dim-hide", "+dim-unhide", "+dim-freeze", "+dim-group", "+dim-ungroup", "+rows-resize", "+cols-resize", "+range-move", "+range-copy", "+range-fill", "+range-sort", "+sheet-create", "+sheet-delete", "+sheet-rename", "+sheet-move", "+sheet-copy", "+sheet-hide", "+sheet-unhide", "+sheet-set-tab-color", + "+sheet-show-gridline", + "+sheet-hide-gridline", "+chart-create", "+chart-update", "+chart-delete", "+pivot-create", "+pivot-update",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@shortcuts/sheets/data/flag-schemas.json` around lines 17 - 68, The enum for batch-update operation shortcuts is missing the new gridline actions; update the enum array in the flag-schemas.json entry for the +batch-update.operations.shortcut (the same enum shown in the diff) to include "+sheet-show-gridline" and "+sheet-hide-gridline" so schema-validated +batch-update payloads accept those batchable operations.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@shortcuts/sheets/lark_sheet_table_io_test.go`:
- Around line 176-181: The test currently checks error messages with
strings.Contains which is fragile; update the t.Run cases (those calling
parseTablePutPayload with stubFlagView{"sheets": tt.json}) to assert structured
error metadata using errs.ProblemOf(err) — verify the Problem.Category,
Problem.Subtype and any Problem.Param match the expected values from the test
case — and also assert cause preservation by unwrapping the returned error
(errors.Unwrap or errors.Is) to compare against the expected cause value in the
table; replace the strings.Contains assertions with these typed checks to cover
category/subtype/param and preserved cause for parseTablePutPayload and the
other indicated test blocks.
In `@shortcuts/sheets/lark_sheet_table_io.go`:
- Around line 399-401: The code is re-wrapping lower-layer errors with
fmt.Errorf which strips typed errs.* classifications; instead, pass through the
original error from lastDataRow (return nil, err) or, if you must add context at
the command layer, wrap using the appropriate errs.* constructor (e.g., errs.New
or another specific errs.* type) while preserving the original as the cause;
update the occurrences that call lastDataRow and similar calls (the append path
around lastDataRow and the other ranges noted) so they either return the
underlying err directly or wrap it with an errs.* typed error rather than
fmt.Errorf/output.Err*.
- Around line 836-838: The returned tableGetSheet for the "--sheet-id" branch
only sets id and drops the existing sheet name, causing downstream output to
emit name:"" and breaking +table-get -> +table-put round trips; update the
branch that returns []tableGetSheet{{...}} to include the original name (e.g.,
[]tableGetSheet{{id: id, name: t.name}}) and also ensure the emitter that writes
name (the code around t.name at the later emission) uses the preserved name
instead of blanking it so both the return path and the emission path keep the
non-empty sheet name.
- Around line 371-380: The function tablePutFullRange can produce invalid ranges
when totalRows is 0 (e.g., "A1:C0"); add an early guard at the top of
tablePutFullRange to return an empty/no-op range string (""), e.g. if totalRows
<= 0 { return "" }, and apply the same fix to the analogous function around the
730-733 block (the tablePutRange implementation) so both return "" when there
are no rows to write; update any callers/tests expecting a no-op behavior if
needed.
---
Outside diff comments:
In `@shortcuts/sheets/data/flag-schemas.json`:
- Around line 17-68: The enum for batch-update operation shortcuts is missing
the new gridline actions; update the enum array in the flag-schemas.json entry
for the +batch-update.operations.shortcut (the same enum shown in the diff) to
include "+sheet-show-gridline" and "+sheet-hide-gridline" so schema-validated
+batch-update payloads accept those batchable operations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 059d6655-5406-414b-b220-3b8d15bc432d
📒 Files selected for processing (31)
shortcuts/drive/drive_export.goshortcuts/drive/drive_export_test.goshortcuts/drive/drive_import.goshortcuts/sheets/batch_op_contract_test.goshortcuts/sheets/batch_op_dispatch.goshortcuts/sheets/data/flag-defs.jsonshortcuts/sheets/data/flag-schemas.jsonshortcuts/sheets/flag_defs_gen.goshortcuts/sheets/flag_schemas_gen.goshortcuts/sheets/lark_sheet_read_data.goshortcuts/sheets/lark_sheet_read_data_test.goshortcuts/sheets/lark_sheet_table_io.goshortcuts/sheets/lark_sheet_table_io_test.goshortcuts/sheets/lark_sheet_workbook.goshortcuts/sheets/lark_sheet_workbook_export_test.goshortcuts/sheets/lark_sheet_workbook_import_test.goshortcuts/sheets/lark_sheet_workbook_test.goshortcuts/sheets/lark_sheet_write_cells.goshortcuts/sheets/shortcuts.goskills/lark-sheets/SKILL.mdskills/lark-sheets/references/lark-sheets-chart.mdskills/lark-sheets/references/lark-sheets-core-operations.mdskills/lark-sheets/references/lark-sheets-filter-view.mdskills/lark-sheets/references/lark-sheets-filter.mdskills/lark-sheets/references/lark-sheets-financial-modeling-standards.mdskills/lark-sheets/references/lark-sheets-range-operations.mdskills/lark-sheets/references/lark-sheets-read-data.mdskills/lark-sheets/references/lark-sheets-visual-standards.mdskills/lark-sheets/references/lark-sheets-workbook.mdskills/lark-sheets/references/lark-sheets-write-cells.mdtests/cli_e2e/sheets/sheets_crud_workflow_test.go
💤 Files with no reviewable changes (1)
- shortcuts/sheets/lark_sheet_read_data_test.go
Comment on lines
+176
to
+181
| t.Run(tt.name, func(t *testing.T) { | ||
| t.Parallel() | ||
| _, err := parseTablePutPayload(stubFlagView{"sheets": tt.json}) | ||
| if err == nil || !strings.Contains(err.Error(), tt.want) { | ||
| t.Errorf("want error containing %q, got %v", tt.want, err) | ||
| } |
There was a problem hiding this comment.
Error-path tests should assert typed problem metadata, not just message substrings.
These assertions currently rely on strings.Contains(...), so category/subtype/param/cause regressions can slip through unnoticed. Please assert errs.ProblemOf(err) metadata (and preserved cause) on error paths.
As per coding guidelines, “Error-path tests must assert typed metadata via errs.ProblemOf (category/subtype/param) and cause preservation, not message substrings alone.”
Also applies to: 291-293, 445-450, 472-479, 502-504, 518-520, 672-674
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@shortcuts/sheets/lark_sheet_table_io_test.go` around lines 176 - 181, The
test currently checks error messages with strings.Contains which is fragile;
update the t.Run cases (those calling parseTablePutPayload with
stubFlagView{"sheets": tt.json}) to assert structured error metadata using
errs.ProblemOf(err) — verify the Problem.Category, Problem.Subtype and any
Problem.Param match the expected values from the test case — and also assert
cause preservation by unwrapping the returned error (errors.Unwrap or errors.Is)
to compare against the expected cause value in the table; replace the
strings.Contains assertions with these typed checks to cover
category/subtype/param and preserved cause for parseTablePutPayload and the
other indicated test blocks.
Source: Coding guidelines
Comment on lines
+371
to
+380
| func tablePutFullRange(s *tableSheetSpec, totalRows int) string { | ||
| _, col0, row0, err := sheetAnchor(s) | ||
| if err != nil { | ||
| return strings.TrimSpace(s.StartCell) | ||
| } | ||
| ncols := len(s.Columns) | ||
| return fmt.Sprintf("%s%d:%s%d", | ||
| columnIndexToLetter(col0), row0+1, | ||
| columnIndexToLetter(col0+ncols-1), row0+totalRows) | ||
| } |
There was a problem hiding this comment.
Dry-run can render an invalid range when there is nothing to write.
When header=false and rows=[], len(matrix)==0, so tablePutFullRange(..., 0) can produce an invalid end row (e.g., A1:C0) in preview output. Return an empty/no-op range string for this case.
Also applies to: 730-733
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@shortcuts/sheets/lark_sheet_table_io.go` around lines 371 - 380, The function
tablePutFullRange can produce invalid ranges when totalRows is 0 (e.g.,
"A1:C0"); add an early guard at the top of tablePutFullRange to return an
empty/no-op range string (""), e.g. if totalRows <= 0 { return "" }, and apply
the same fix to the analogous function around the 730-733 block (the
tablePutRange implementation) so both return "" when there are no rows to write;
update any callers/tests expecting a no-op behavior if needed.
Comment on lines
+399
to
+401
| lastRow, err := lastDataRow(ctx, runtime, token, sheetID) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("resolving last data row for append: %w", err) |
There was a problem hiding this comment.
Use typed errs.* errors and avoid downgrading lower-layer typed errors.
These paths currently re-wrap with fmt.Errorf and return output.Errorf / output.ExitError, which drops the typed error contract expected by command-facing failures.
As per coding guidelines, “Command-facing failures must be typed errs.* errors — never use legacy output.Err* helpers or bare fmt.Errorf,” and “Pass through lower-layer typed errors unchanged — re-wrapping downgrades their classification.”
Also applies to: 529-550, 653-653, 679-706
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@shortcuts/sheets/lark_sheet_table_io.go` around lines 399 - 401, The code is
re-wrapping lower-layer errors with fmt.Errorf which strips typed errs.*
classifications; instead, pass through the original error from lastDataRow
(return nil, err) or, if you must add context at the command layer, wrap using
the appropriate errs.* constructor (e.g., errs.New or another specific errs.*
type) while preserving the original as the cause; update the occurrences that
call lastDataRow and similar calls (the append path around lastDataRow and the
other ranges noted) so they either return the underlying err directly or wrap it
with an errs.* typed error rather than fmt.Errorf/output.Err*.
Source: Coding guidelines
Comment on lines
+836
to
+838
| if id != "" { | ||
| return []tableGetSheet{{id: id}}, nil | ||
| } |
There was a problem hiding this comment.
Preserve a non-empty sheet name when --sheet-id is used.
Line 837 returns a target with only id, and Line 872 emits name from t.name, so the output can contain name: "". That breaks +table-get -> +table-put round-tripping because +table-put requires non-empty sheet names.
💡 Minimal fix
if id != "" {
- return []tableGetSheet{{id: id}}, nil
+ // Prefer resolving real sheet name from workbook structure; fallback keeps output valid.
+ return []tableGetSheet{{id: id, name: id}}, nil
}Also applies to: 872-873
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@shortcuts/sheets/lark_sheet_table_io.go` around lines 836 - 838, The returned
tableGetSheet for the "--sheet-id" branch only sets id and drops the existing
sheet name, causing downstream output to emit name:"" and breaking +table-get ->
+table-put round trips; update the branch that returns []tableGetSheet{{...}} to
include the original name (e.g., []tableGetSheet{{id: id, name: t.name}}) and
also ensure the emitter that writes name (the code around t.name at the later
emission) uses the preserved name instead of blanking it so both the return path
and the emission path keep the non-empty sheet name.
Add `counta` (count non-empty cells, incl. text) to manage_chart_object dim2.series[].aggregateType in the chart flag schema. `count` only counts numeric cells, so counting occurrences of a text/category column renders an empty chart; `counta` enables category frequency counts. Synced from the sheet-skill-spec canonical schema.
…n +pivot-create Both flags map to the same wire field (properties.range), so passing non-default values for both is ambiguous. Mirror the --target-sheet-id / --target-sheet-name mutex pattern: --target-position takes priority over --range, and supplying both with non-default values is rejected up front with a typed FlagErrorf. --target-position=A1 is the documented default and is treated as "not set". Add a symmetric validateCreateInput hook on objectCRUDSpec (alongside the existing validateUpdateInput), wire it into objectCreateInput, and inject the pivot-specific check on pivotSpec.
feat(sheets): add counta to chart aggregateType enum
- --values builds a type-less typed payload, writing through --sheets' batched set_cell_range path (raw passthrough preserves auto-detect; large tables batch; big ints via json.Number) - drop --headers (subsumed by --values first row) and --header-style (typed header no longer auto-bold; use --styles instead) - styles: deep-merge overlapping cell_styles/border_styles fields (was wholesale-replace which dropped fields); add manual border_styles validation (style/weight enums + sides) since --styles is on parseJSONFlagSkip and bypasses the schema validator - regenerate flag-defs/flag-schemas/skills mirror from sheet-skill-spec (--styles flag + full per-side border schema)
…eat/lark-sheets-develop
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
shortcuts/sheets/lark_sheet_workbook_test.go (1)
431-450:⚠️ Potential issue | 🟠 Major | ⚡ Quick winUse typed error assertions instead of substring matching for these new negative-path cases.
These new cases assert failures via message substrings, which is brittle and misses typed error contract checks (
category/subtype/param+ cause). Please assert via typed error metadata (errs.ProblemOfanderrors.Asfor validationParam) for each error-path case.As per coding guidelines, “
**/*_test.go: Error-path tests must assert typed metadata viaerrs.ProblemOf(category/subtype/param) and cause preservation, not message substrings alone.”🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@shortcuts/sheets/lark_sheet_workbook_test.go` around lines 431 - 450, The test currently checks failure cases by substring matching on stdout/stderr/err; update the table-driven tests using WorkbookCreate and runShortcutCapturingErr to assert typed error metadata instead: for each case ensure err != nil, call errs.ProblemOf(err) and compare the returned Problem's Category/Subtype/Param to the expected values for that scenario, and use errors.As to extract and assert the concrete validation Param/cause where applicable to preserve the underlying cause; replace the strings.Contains(...) assertion block with these typed checks (using errs.ProblemOf and errors.As) so tests validate the error contract rather than message substrings.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@shortcuts/sheets/lark_sheet_workbook_test.go`:
- Around line 431-450: The test currently checks failure cases by substring
matching on stdout/stderr/err; update the table-driven tests using
WorkbookCreate and runShortcutCapturingErr to assert typed error metadata
instead: for each case ensure err != nil, call errs.ProblemOf(err) and compare
the returned Problem's Category/Subtype/Param to the expected values for that
scenario, and use errors.As to extract and assert the concrete validation
Param/cause where applicable to preserve the underlying cause; replace the
strings.Contains(...) assertion block with these typed checks (using
errs.ProblemOf and errors.As) so tests validate the error contract rather than
message substrings.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ea9b5e28-5ad3-4f14-aa4f-17d32e3d2b56
📒 Files selected for processing (12)
shortcuts/sheets/data/flag-defs.jsonshortcuts/sheets/data/flag-schemas.jsonshortcuts/sheets/execute_paths_test.goshortcuts/sheets/flag_defs_gen.goshortcuts/sheets/flag_schema_validate.goshortcuts/sheets/lark_sheet_table_io.goshortcuts/sheets/lark_sheet_table_io_test.goshortcuts/sheets/lark_sheet_workbook.goshortcuts/sheets/lark_sheet_workbook_test.goskills/lark-sheets/SKILL.mdskills/lark-sheets/references/lark-sheets-workbook.mdskills/lark-sheets/references/lark-sheets-write-cells.md
💤 Files with no reviewable changes (1)
- skills/lark-sheets/references/lark-sheets-write-cells.md
✅ Files skipped from review due to trivial changes (1)
- skills/lark-sheets/SKILL.md
🚧 Files skipped from review as they are similar to previous changes (4)
- shortcuts/sheets/lark_sheet_table_io_test.go
- shortcuts/sheets/data/flag-schemas.json
- shortcuts/sheets/lark_sheet_table_io.go
- shortcuts/sheets/lark_sheet_workbook.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the
feat/lark-sheets-developline up to date withmain(merged in, no conflicts) and lands the accumulated Lark Sheets work for review intomain: typed table I/O, workbook import/export, gridline shortcuts, and a broadlark-sheetsskill/doc refresh.Changes
+table-put/+table-getshortcuts for DataFrame-style typed import/export with column type & number-format preservation (lark_sheet_table_io.go, +1148 LOC with tests).+workbook-importwrapping the drive import core;+workbook-exportrefactored to reuse the drive export core (drive_import.go/drive_export.go).+sheet-show-gridline/+sheet-hide-gridline.skills/lark-sheetsrefresh — new financial-modeling-standards reference plus chart / filter / read-data / write-cells / workbook references andSKILL.mdrouting updates.flag_defs_gen.goto matchdata/flag-defs.json(codegen drift); tightenedrowstyping inlark_sheet_table_io.goto clear anasasalintfinding.Test Plan
go test -race ./cmd/... ./internal/... ./shortcuts/... ./extension/...go build ./...,golangci-lint run --new-from-rev=origin/main(0 issues), andgofmtall cleanlark-cli sheets <command>end-to-end verification (not run this round)tests/cli_e2e) — not run locally (requires live credentials)Related Issues
Summary by CodeRabbit
New Features
Enhancements
Removals
Documentation